Bugzilla – Full Text Bug Listing |
Summary: | trace helpers too inclusive | ||
---|---|---|---|
Product: | ns-3 | Reporter: | Tom Henderson <tomh> |
Component: | helpers | Assignee: | Mathieu Lacage <mathieu.lacage> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | craigdo, kunalkerkar, ns-bugs |
Priority: | P3 | ||
Version: | ns-3.1 | ||
Hardware: | All | ||
OS: | All | ||
Bug Depends on: | 284 | ||
Bug Blocks: | |||
Attachments: |
possible run-time check
patch based on API in bug 284 |
Description
Tom Henderson
2008-08-11 00:36:08 EDT
Created attachment 226 [details]
possible run-time check
This patch is not complete; it could be extended to add checks to the EnablePcap() variants using nodeId and deviceId, and also to EnableAscii() methods.
Similar patch needed for WifiHelper and PointToPointHelper.
While the additional error checking you mention here is not a bad idea, I am worried that doing this adds a lot more intelligence in the helpers than we would like. I think that a much better and much more useful solution would be to try to figure out better semantics for Config::Connect* and figure out a way to report useful and meaningful trace connection errors and successes to the user. The hard part is defining exactly the user-model here (other than "do-what-i-mean"). With the API in bug 284, we don't need to check explicitely for the right device type here. We can just iterate over all matching objects. Created attachment 273 [details] patch based on API in bug 284 (In reply to comment #4) > Created an attachment (id=273) [details] > patch based on API in bug 284 > Yes, this looks like a good solution-- OK by me. I pushed a simpler patch along the same lines for csma, point to point, and wifi. changeset: 616c83eeb4b9 |