Bug 1052 – olsr::RoutingProtocol::LinkTupleUpdated incorrect detection of asymetric link with multiple interface nodes

Bug 1052 - olsr::RoutingProtocol::LinkTupleUpdated incorrect detection of asymetric link with multiple interface nodes


Summary:	olsr::RoutingProtocol::LinkTupleUpdated incorrect detection of asymetric link...

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	olsr
Version:	ns-3-dev
Hardware:	All All

Importance:	P5 normal
Assigned To:	Gustavo J. A. M. Carneiro

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-02-09 12:25 EST by Gustavo J. A. M. Carneiro
Modified:	2011-02-16 14:21 EST (History)
CC List:	2 users (show)

See Also:

Attachments
Fix (1.05 KB, patch) 2011-02-15 14:18 EST, Lalith Suresh	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gustavo J. A. M. Carneiro 2011-02-09 12:25:47 EST

olsr::RoutingProtocol::LinkTupleUpdated considers a link to a neighbor asymetric if any link to the neighbor is asymetric.  However, it should consider the neighbor symetric if there is at least one symjetric link to it.  The current code works as expected only when not using multiple interfaces.

RFC 3626 sect. 8.1:
               If the neighbor has any associated link tuple which
               indicates a symmetric link (i.e., with L_SYM_time >=
               current time), then

                    N_status is set to SYM

               else N_status is set to NOT_SYM

This problem was reported in [1].

[1] http://groups.google.com/group/ns-3-users/msg/66bb050e61662995

Comment 1 Lalith Suresh 2011-02-15 14:18:19 EST

Created attachment 1035 [details]
Fix

I didn't test it per se, but will this do?

Comment 2 Gustavo J. A. M. Carneiro 2011-02-16 06:56:35 EST

(In reply to comment #1)
> Created attachment 1035 [details]
> Fix
> 
> I didn't test it per se, but will this do?

Yes, it sounds like it fixes the problem.  And at least doesn't seem to break any regression tests.  Feel free to commit.

Comment 3 Lalith Suresh 2011-02-16 14:21:01 EST

changeset:   6820:a09e1a107172
tag:         tip
user:        Lalith Suresh <suresh.lalith@gmail.com>
date:        Wed Feb 16 19:09:58 2011 +0000
summary:     Bug 1052 - olsr::RoutingProtocol::LinkTupleUpdated incorrect detection of asymmetric link with multiple interface node