Bug 157 – IP layer tracing is unavailable in the new helper API

Bug 157 - IP layer tracing is unavailable in the new helper API

Summary:

IP layer tracing is unavailable in the new helper API

Status:	RESOLVED FIXED

Product:	ns-3
Component:	samples
Version:	pre-release
Platform:	All All

Importance:	P3 normal
Assigned To:	ns-bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-04-01 21:32 EDT by Rajib Bhattacharjea
Modified:	2008-07-01 13:32 EDT (History)

Attachments
patch to InternetStackHelper implementing IP layer tracing (4.24 KB, patch) 2008-04-01 21:33 EDT, Rajib Bhattacharjea	Details \| Diff
Update to previous patch for "static" semantics (4.45 KB, patch) 2008-04-02 12:51 EDT, Rajib Bhattacharjea	Details \| Diff
Hide Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description From Rajib Bhattacharjea 2008-04-01 21:32:25 EDT

And Mathieu mentioned he envisions the PcapTrace being worked out of our code
at some point in favor of a helper.

The patch essentially copies the current PcapTrace functionality into
InternetStackHelper, i.e. 

InternetStackHelper internet;
internet.EnablePcap("traceName");

------- Comment #1 From Rajib Bhattacharjea 2008-04-01 21:33:14 EDT -------

Created an attachment (id=121) [details]
patch to InternetStackHelper implementing IP layer tracing

------- Comment #2 From Mathieu Lacage 2008-04-01 21:53:43 EDT -------

Looks awesome but, for consistency, EnablePcap should be static and, once you
have done this, the tcp example script should be updated to use the non-member
method syntax.

------- Comment #3 From Rajib Bhattacharjea 2008-04-02 12:51:15 EDT -------

Created an attachment (id=122) [details]
Update to previous patch for "static" semantics

Here is a slightly modified implementation with static function semantics
instead of method semantics, i.e.
InternetStackHelper::EnablePcap("tracefilename")

------- Comment #4 From Mathieu Lacage 2008-04-02 12:58:36 EDT -------

looks good to me. feel free to apply as this looks like a trivial addition.

------- Comment #5 From Rajib Bhattacharjea 2008-04-02 13:07:10 EDT -------

Pushed in ns-3-dev as:
2845:2398826af6b4