Bug 219 - Ipv4Interface is a poor API
: Ipv4Interface is a poor API
Status: RESOLVED FIXED
: ns-3
node module
: pre-release
: All All
: P2 normal
Assigned To:
:
:
:
: 384
  Show dependency treegraph
 
Reported: 2008-06-11 20:00 EDT by
Modified: 2009-05-29 17:39 EDT (History)


Attachments


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2008-06-11 20:00:44 EDT
Ipv4.h has inconsistent method naming and misleading or duplicated method
names.  Related problem with Ipv4RoutingProtocol.

Some methods named Find This or That and return uint32 index.
Some methods named Get This or that and return uint32 index.
Some methods take an index for an Ipv4Interface called i.
Some methods take an index for an Ipv4Interface called ifIndex.
Some methods take an index for an Ipv4Interface called interface.

IfIndex is an overloaded term and shouldn't appear here.

Some methods are misleading.  FindIfIndexForDevice implies there is only one
interface allowed per device.

Some methods are duplicated?  FindInterfaceForAddr, GetIfIndexByAddress.

This is not very pretty.
------- Comment #1 From 2009-02-16 01:02:16 EDT -------
sliding to ns-3.5
------- Comment #2 From 2009-05-29 17:39:19 EDT -------
changeset e20a31541404