Bug 270 - Simulator::RunOneEvent
: Simulator::RunOneEvent
Status: RESOLVED FIXED
: ns-3
simulation core
: pre-release
: All All
: P3 normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2008-08-05 10:50 EDT by
Modified: 2008-08-06 12:42 EDT (History)


Attachments
patch (2.02 KB, patch)
2008-08-05 10:50 EDT, Gustavo J. A. M. Carneiro
Details | Diff
new patch (4.07 KB, patch)
2008-08-06 06:02 EDT, Gustavo J. A. M. Carneiro
Details | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2008-08-05 10:50:24 EDT
Please make Simulator::ProcessOneEvent available as public API.
------- Comment #1 From 2008-08-05 10:50:54 EDT -------
Created an attachment (id=219) [details]
patch
------- Comment #2 From 2008-08-05 11:20:33 EDT -------
Please, rename the public API to RunOne to outline the relationship with
Simulator::Run better.
------- Comment #3 From 2008-08-05 12:00:52 EDT -------
(In reply to comment #2)
> Please, rename the public API to RunOne to outline the relationship with
> Simulator::Run better.
> 

OK.

After filing this bug I discovered a potential solution that may allow me to do
my viz thing without this API, so I put this on hold until it is sorted out.
------- Comment #4 From 2008-08-05 12:46:27 EDT -------
(In reply to comment #2)
> Please, rename the public API to RunOne to outline the relationship with
> Simulator::Run better.

I still think RunOne is a poor name.  RunOne?  RunOne what?  ProcessOneEvent
was fine.  How about RunOneEvent or RunFirstEvent?

Please don't take the private member method ProcessOneEvent and just make it
public and callable by anyone.  The multithreaded and real time schedulers
re-implement ProcessOneEvent treating it as a private method.  This is not
going to work.  If you are going to add a new bit of public API, please do that
and define a new method.
------- Comment #5 From 2008-08-05 12:50:45 EDT -------
(In reply to comment #4)

> I still think RunOne is a poor name.  RunOne?  RunOne what?  ProcessOneEvent
> was fine.  How about RunOneEvent or RunFirstEvent?

RunOneEvent would be fine with me.

> 
> Please don't take the private member method ProcessOneEvent and just make it
> public and callable by anyone.  The multithreaded and real time schedulers
> re-implement ProcessOneEvent treating it as a private method.  This is not
> going to work.  If you are going to add a new bit of public API, please do that
> and define a new method.

agreed.
------- Comment #6 From 2008-08-06 05:59:56 EDT -------
I think I am going to need this after all.
------- Comment #7 From 2008-08-06 06:02:53 EDT -------
Created an attachment (id=220) [details]
new patch

I think this is what is wanted.  OK to commit?
------- Comment #8 From 2008-08-06 11:06:34 EDT -------
ok for me.
------- Comment #9 From 2008-08-06 12:42:20 EDT -------
changeset:   3515:88e9cee20461