Bug 279 – Packets need metadata support for printing without header checking

Bug 279 - Packets need metadata support for printing without header checking

Summary:

Packets need metadata support for printing without header checking

Status:	RESOLVED FIXED

Product:	ns-3
Component:	simulation core
Version:	pre-release
Platform:	All All

Importance:	P3 normal
Assigned To:	ns-bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-08-09 13:58 EDT by Mathieu Lacage
Modified:	2008-08-25 18:13 EDT (History)

Attachments
add EnableChecking and EnablePrinting (7.57 KB, patch) 2008-08-11 13:17 EDT, Mathieu Lacage	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description From Mathieu Lacage 2008-08-09 13:58:24 EDT

there are lots of cases where we want to enable the packet metadata to be able
to print the content of the packet but where we don't want to enable the packet
error checking. 

We could add the following functions:

class Packet
{
public:
  static void EnableChecking (void);
  static void DisableChecking (void);
};

the default would be no checking to be consistent with the "no metadata"
default.

------- Comment #1 From Tom Henderson 2008-08-10 13:26:01 EDT -------

+1

------- Comment #2 From Craig Dowell 2008-08-10 14:33:37 EDT -------

+1

------- Comment #3 From Mathieu Lacage 2008-08-11 13:17:18 EDT -------

Created an attachment (id=227) [details]
add EnableChecking and EnablePrinting

------- Comment #4 From Mathieu Lacage 2008-08-11 13:18:19 EDT -------

Packet::EnableMetadata is made deprecated. Packet::EnablePrinting allows you to
call Packet::Print successfully. Packet::EnableChecking enables error checking.

please, review.

------- Comment #5 From Tom Henderson 2008-08-25 13:04:04 EDT -------

(In reply to comment #4)
> Packet::EnableMetadata is made deprecated. Packet::EnablePrinting allows you to
> call Packet::Print successfully. Packet::EnableChecking enables error checking.
> 
> please, review.
> 

I reviewed this patch and it looks good to me.

------- Comment #6 From Mathieu Lacage 2008-08-25 18:13:56 EDT -------

changeset: 065488d0420c