Bug 282 – Ipv4L4Demux is useful ?

Bug 282 - Ipv4L4Demux is useful ?

Summary:

Ipv4L4Demux is useful ?

Status:	RESOLVED FIXED

Product:	ns-3
Component:	internet-stack
Version:	pre-release
Platform:	All All

Importance:	P3 normal
Assigned To:	ns-bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-08-11 17:23 EDT by Mathieu Lacage
Modified:	2008-09-02 20:23 EDT (History)

Attachments
move Ipv4L4Demux functionality to Ipv4L3Protocol. (84.87 KB, patch) 2008-08-30 00:23 EDT, Mathieu Lacage	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description From Mathieu Lacage 2008-08-11 17:23:29 EDT

I can't figure out why this code has not been merged in the Ipv4L3Protocol
class and the Insert method made a public method of Ipv4L3Protocol.

Is there someone who knows this ?

------- Comment #1 From Mathieu Lacage 2008-08-30 00:23:54 EDT -------

Created an attachment (id=236) [details]
move Ipv4L4Demux functionality to Ipv4L3Protocol.

------- Comment #2 From Rajib Bhattacharjea 2008-09-02 13:35:48 EDT -------

I am okay with this patch. I think we need to solicit some feedback from
George, but I can't seem to add George as a CC...

------- Comment #3 From Mathieu Lacage 2008-09-02 13:40:14 EDT -------

this is because george has no bugzilla account

------- Comment #4 From Rajib Bhattacharjea 2008-09-02 15:25:58 EDT -------

(In reply to comment #2)
> I am okay with this patch. I think we need to solicit some feedback from
> George, but I can't seem to add George as a CC...
> 

George has an account now, but that was another bug :-)

After speaking with him, the utility of it was simply logical separation
between layer three, and the interface between layer three and layer four. 
That said, he doesn't feel strongly enough about this to prevent what you
suggest.

There are lots of "changes" (which look like they aren't really changes) to the
python bindings in this diff...I guess this is a result of running the
pybindgen scanner for the updated API?  So long as this is the case, please
feel free to apply.

------- Comment #5 From Mathieu Lacage 2008-09-02 15:42:31 EDT -------

(In reply to comment #4)
> (In reply to comment #2)
> > I am okay with this patch. I think we need to solicit some feedback from
> > George, but I can't seem to add George as a CC...
> > 
> 
> George has an account now, but that was another bug :-)
> 
> After speaking with him, the utility of it was simply logical separation
> between layer three, and the interface between layer three and layer four. 
> That said, he doesn't feel strongly enough about this to prevent what you
> suggest.
> 
> There are lots of "changes" (which look like they aren't really changes) to the
> python bindings in this diff...I guess this is a result of running the
> pybindgen scanner for the updated API?  So long as this is the case, please
> feel free to apply.

yes, this is the result of running the scanner. 

>

------- Comment #6 From Mathieu Lacage 2008-09-02 20:23:36 EDT -------

changeset ad0a36bfdb62