Bug 352 – Wifi STA mac address problems

Bug 352 - Wifi STA mac address problems

Summary:

Wifi STA mac address problems

Status:	RESOLVED FIXED

Product:	ns-3
Component:	devices
Version:	ns-3.2
Platform:	All All

Importance:	P3 normal
Assigned To:	Mathieu Lacage

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-09-17 13:33 EDT by Gustavo J. A. M. Carneiro
Modified:	2008-10-16 06:47 EDT (History)

Attachments
patch to fix it (1.10 KB, patch) 2008-09-17 13:34 EDT, Gustavo J. A. M. Carneiro	Details \| Diff
foo (538 bytes, patch) 2008-10-16 06:27 EDT, Mathieu Lacage	Details \| Diff
Hide Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description From Gustavo J. A. M. Carneiro 2008-09-17 13:33:28 EDT

In Wifi infrastructure more:
1. STA X sends a broadcast
2. AP Y retransmits the broadcast for all nodes to receive
3. STA X receives the retransmission and receives it

Step 3 is bad, the STA should not forward to the upper layers broadcasts that
it has sent.

------- Comment #1 From Gustavo J. A. M. Carneiro 2008-09-17 13:34:19 EDT -------

Created an attachment (id=258) [details]
patch to fix it

------- Comment #2 From Mathieu Lacage 2008-10-16 04:49:34 EDT -------

I would suggest to check for hdr->GetAddr3 () from the caller rather than from
the callee. i.e., ForwardUp should not be doing the address check. Its caller
should.

------- Comment #3 From Gustavo J. A. M. Carneiro 2008-10-16 06:15:42 EDT -------

OK, but that would mean changing the signature of ForwardUp to include a new
address argument.

------- Comment #4 From Mathieu Lacage 2008-10-16 06:27:55 EDT -------

Created an attachment (id=265) [details]
foo

please, test the attached.

------- Comment #5 From Gustavo J. A. M. Carneiro 2008-10-16 06:45:27 EDT -------

(From update of attachment 265 [details])
It fixes the bug.

------- Comment #6 From Mathieu Lacage 2008-10-16 06:47:28 EDT -------

changeset d26d57ddf801