Bug 37 – NS_TEST_ASSERT_EQUAL

Bug 37 - NS_TEST_ASSERT_EQUAL

Summary:

NS_TEST_ASSERT_EQUAL

Status:	RESOLVED FIXED

Product:	ns-3
Component:	simulation core
Version:	pre-release
Platform:	PC Linux

Importance:	P1 blocker
Assigned To:	ns-bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2007-06-15 12:36 EDT by Gustavo J. A. M. Carneiro
Modified:	2008-07-01 13:32 EDT (History)

Attachments
patch (adds line number, docs, adds NS_TEST_ASSERT macro) (1.72 KB, patch) 2007-06-18 08:20 EDT, Gustavo J. A. M. Carneiro	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description From Gustavo J. A. M. Carneiro 2007-06-15 12:36:22 EDT

I have found this macro useful in unit tests:

#define NS_TEST_ASSERT_EQUAL(got, expected)                     \
    if (got != expected)                                        \
      {                                                         \
        Failure () << __FILE__ << ": expected " << expected     \
                   << ", but got " << got << std::endl;         \
        result = false;                                         \
      }

E.g.:
[...]
    packet.RemoveHeader (hdr);
    NS_TEST_ASSERT_EQUAL (hdr.m_packetSequenceNumber, 123);

A similar NS_TEST_ASSERT(expression_that_must_be_true) macro could easily be
derived...

------- Comment #1 From Mathieu Lacage 2007-06-16 04:15:50 EDT -------

Looks good. Are you willing to add this to test.h ? It would be nice to add the
line number to the output too.

------- Comment #2 From Gustavo J. A. M. Carneiro 2007-06-18 08:20:46 EDT -------

Created an attachment (id=23) [details]
patch (adds line number, docs, adds NS_TEST_ASSERT macro)

------- Comment #3 From Tom Henderson 2007-06-18 09:46:13 EDT -------

+1

------- Comment #4 From Gustavo J. A. M. Carneiro 2007-06-18 10:57:22 EDT -------

Committed to ns-3-dev.