Bug 482 – Add constant acceleration mobility model

Bug 482 - Add constant acceleration mobility model


Summary:	Add constant acceleration mobility model

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	mobility models
Version:	ns-3-dev
Hardware:	All All

Importance:	P5 enhancement
Assigned To:	Mathieu Lacage

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-01-28 13:29 EST by Gustavo J. A. M. Carneiro
Modified:	2009-03-10 09:28 EDT (History)
CC List:	2 users (show)

See Also:

Attachments
the patch (5.58 KB, patch) 2009-01-28 13:29 EST, Gustavo J. A. M. Carneiro	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gustavo J. A. M. Carneiro 2009-01-28 13:29:54 EST

Created attachment 364 [details]
the patch

I wrote a ConstantAccelerationMobilityModel which could be useful to others.

Comment 1 Mathieu Lacage 2009-02-25 05:29:16 EST

this patch looks good to me. I am not too fond of the naming from a consistency perspective: if you want to use 'Constant' instead of 'Static', we need to change the existing 'Static' models. Otherwise, I would tend to rename your 'Constant' into 'Static'.

What do you prefer ?

Comment 2 Gustavo J. A. M. Carneiro 2009-02-25 06:00:42 EST

I'd rename StaticSpeedMobilityModel to ConstantSpeedMobilityModel.  But StaticMobilityModel should of course remain unchanged; it really is static, so the name makes perfect sense.

Comment 3 Mathieu Lacage 2009-02-25 06:26:55 EST

(In reply to comment #2)
> I'd rename StaticSpeedMobilityModel to ConstantSpeedMobilityModel.  But
> StaticMobilityModel should of course remain unchanged; it really is static, so
> the name makes perfect sense.
> 

hrm. How about ConstantPositionMobilityModel, ConstantSpeedMobilityModel, and, ConstantAccelerationMobilityModel ?

Comment 4 Gustavo J. A. M. Carneiro 2009-02-25 06:40:13 EST

(In reply to comment #3)
> (In reply to comment #2)
> > I'd rename StaticSpeedMobilityModel to ConstantSpeedMobilityModel.  But
> > StaticMobilityModel should of course remain unchanged; it really is static, so
> > the name makes perfect sense.
> > 
> 
> hrm. How about ConstantPositionMobilityModel, ConstantSpeedMobilityModel, and,
> ConstantAccelerationMobilityModel ?
> 

That sounds good.

But it is a lot of API change.  While it won't affect me personally (since I'll keep using a patched ns 3.2), maybe it's better to ask in ns-developers?  And this change would be for ns-3.4 or later?

Comment 5 Mathieu Lacage 2009-03-10 09:28:19 EDT

changeset e57ced8f6660