Bug 562 – bug in TagBuffer.cc - TagBuffer::WriteU64

Bug 562 - bug in TagBuffer.cc - TagBuffer::WriteU64

Summary:

bug in TagBuffer.cc - TagBuffer::WriteU64

Status:	RESOLVED FIXED

Product:	ns-3
Component:	simulation core
Version:	ns-3-dev
Platform:	All All

Importance:	P5 major
Assigned To:	ns-bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-05-09 09:31 EDT by Tommaso Pecorella
Modified:	2009-06-19 03:07 EDT (History)

Attachments
patch for the tagbuffer bug (366 bytes, patch) 2009-06-10 11:42 EDT, Tommaso Pecorella	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description From Tommaso Pecorella 2009-05-09 09:31:55 EDT

Terrible suspect after seeing the change in buffer.cc. Suspect confirmed.

TagBuffer.cc, line 102 should be: 
  WriteU8 ((data >> 56) & 0xff);
instead of
  WriteU8 ((data >> 54) & 0xff);


Cheers

------- Comment #1 From Mathieu Lacage 2009-05-19 09:25:03 EDT -------

already fixed in ns-3-dev. see changeset 9491c5faaec6

------- Comment #2 From Tommaso Pecorella 2009-06-10 10:50:13 EDT -------

It seems that the bug is still there.

Maybe a wrong commit.

Cheers

------- Comment #3 From Mathieu Lacage 2009-06-10 10:52:55 EDT -------

ah, ok. well, patch + test, please ?

------- Comment #4 From Tommaso Pecorella 2009-06-10 11:42:37 EDT -------

Created an attachment (id=464) [details]
patch for the tagbuffer bug

------- Comment #5 From Mathieu Lacage 2009-06-19 03:07:04 EDT -------

changeset 7473ca619bc7