Bug 602 - WifiRemoteStation lacks information about the access class of outgoing packets
WifiRemoteStation lacks information about the access class of outgoing packets
Status: RESOLVED FIXED
Product: ns-3
Classification: Unclassified
Component: wifi
ns-3-dev
All All
: P2 critical
Assigned To: Mathieu Lacage
:
: 717 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-06-22 10:46 EDT by Mathieu Lacage
Modified: 2010-02-26 02:39 EST (History)
3 users (show)

See Also:


Attachments
Add retry counters for QoS stations. (15.03 KB, patch)
2009-09-11 09:36 EDT, Mirko Banchi
Details | Diff
Patch v2 (18.76 KB, patch)
2009-10-22 09:37 EDT, Mirko Banchi
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Lacage 2009-06-22 10:46:45 EDT
see thread:
http://mailman.isi.edu/pipermail/ns-developers/2009-May/005927.html
Comment 1 Mirko Banchi 2009-09-11 09:36:22 EDT
Created attachment 585 [details]
Add retry counters for QoS stations.

This patch should resolv problem of shared counters for QoS and Non-QoS packets.
Interested classes are:

ns3::WifiRemoteStation
ns3::DcaTxop
ns3::EdcaTxopN
ns3::MacLow

When a packet (data or cts) is correctly/incorrectly received is called relative method in WifiRemoteStation with indication of the access class which packet belongs in order to update correct retry counter.
Comment 2 Mirko Banchi 2009-10-22 09:37:45 EDT
Created attachment 639 [details]
Patch v2

This patch adds also TracedSources for new counters.
Comment 3 Kirill Andreev 2009-10-22 09:57:19 EDT
*** Bug 717 has been marked as a duplicate of this bug. ***
Comment 4 Kirill Andreev 2009-12-02 06:34:20 EST
Have I understood correctly, that the only thing, that prevents this bug from being fixed, is rate control, which may start to work incorrectly? Is it possible to move retry counters from WifiRemoteStationManager to DcaTxop (as soon as it is responsible for packet retransmission and fragmentation), and change interface to rate control as follows: when a packet has been transmitted or failed, we give AC, retry counter, and packet itself to the rate control? I think, that it is closer to real-life situation (specially, some real rate control algorithms use such interface), but a huge amount of code must be changed. Another approach is not to touch rate-control dependent part of WifiRemoteStationManager and move retry counters to DcaTxop only (because I have not found any contraries with a standard).
Comment 5 Kirill Andreev 2010-01-25 06:38:13 EST
When I was writing a patch, which fixes airtime link metric
(see proposed fix of this bug here: http://code.nsnam.org/mathieu/ns-3-bug602/), I have observed, that rate control does not wokr any more.
Are there any news about fixing this?
Comment 6 Kirill Andreev 2010-02-26 02:39:47 EST
Changeset 4329a1519b3e and merging ns-3-bug-602.