Bug 699 – TestCase::DoRun probably should not return a bool

Bug 699 - TestCase::DoRun probably should not return a bool

Summary:

TestCase::DoRun probably should not return a bool

Status:	NEW

Product:	ns-3
Component:	simulation core
Version:	pre-release
Platform:	All All

Importance:	P5 normal
Assigned To:	Craig Dowell

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-10-01 07:29 EDT by Mathieu Lacage
Modified:	2010-01-04 14:48 EDT (History)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description From Mathieu Lacage 2009-10-01 07:29:51 EDT

It would be simpler for all testcases if we did not have to return something
and merely used the status of TestCase::m_error as set by ReportFailure.

------- Comment #1 From Mathieu Lacage 2009-11-24 04:37:38 EDT -------

assigning to craig.

------- Comment #2 From Craig Dowell 2010-01-04 14:48:28 EDT -------

This will avoid the single line

  return GetErrorStatus ()

at the end of a test case implementation.  This is a conceptually simple thing
to address but to do this would require touching many, many, many files all
over the system.

If someone feels very strongly about it I can do this, but it really doesn't
seem worth it.  I would absolutely not recommend trying to address this during
a maintenance phase.