Bug 729 – IPv6 over PPP

Bug 729 - IPv6 over PPP

Summary:

IPv6 over PPP

Status:	RESOLVED FIXED

Product:	ns-3
Component:	devices
Version:	ns-3-dev
Platform:	All All

Importance:	P4 normal
Assigned To:	ns-bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-10-22 05:13 EDT by Fabian Mauchle
Modified:	2009-11-12 03:24 EDT (History)

Attachments
patch (5.54 KB, patch) 2009-10-22 05:13 EDT, Fabian Mauchle	Details \| Diff
patch (replaces old one) (5.85 KB, patch) 2009-10-22 08:47 EDT, Fabian Mauchle	Details \| Diff
Hide Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description From Fabian Mauchle 2009-10-22 05:13:23 EDT

Created an attachment (id=636) [details]
patch

IPv6 can currently not communicate over a Point-to-Point link because its
header has a hardcoded protocol value for IPv4.

The patch adds a protocol field to the Point-to-Point-Header and some methods
to convert between PPP- and Ethernet- protocol numbers.

------- Comment #1 From Sebastien Vincent 2009-10-22 07:51:55 EDT -------

Patch looks good.

Some (very very) minor comments:
- According to our naming convention: PPPtoETHER -> PppToEther and ETHERtoPPP
-> EtherToPpp;
- \param and \return doxygen for PppToEther and EtherToPpp methods;
- Doxygen for m_protocol member.

(In reply to comment #0)
> Created an attachment (id=636) [details] [details]
> patch
> 
> IPv6 can currently not communicate over a Point-to-Point link because its
> header has a hardcoded protocol value for IPv4.
> 
> The patch adds a protocol field to the Point-to-Point-Header and some methods
> to convert between PPP- and Ethernet- protocol numbers.
>

------- Comment #2 From Fabian Mauchle 2009-10-22 08:47:41 EDT -------

Created an attachment (id=637) [details]
patch (replaces old one)

Minor changes requested by Sebastien

------- Comment #3 From Sebastien Vincent 2009-11-12 03:24:26 EDT -------

Merge in revision c305c6e122c9