# HG changeset patch # User Andrey Mazo # Date 1358774340 -14400 # Node ID 7fd88140c036e40dc3b17cf6fb67a029c41fdb1d # Parent b72fd6e6a4b5d46d5f77c41f14681dc5d1618ab1 make non-static global debugging-only functions static inline (bug 1170). Compilers shouldn't warn on unused static inline function and just don't emit code for them in optimized builds. Also debugging-only functions don't pollute symbol tables. diff --git a/examples/energy/energy-model-example.cc b/examples/energy/energy-model-example.cc --- a/examples/energy/energy-model-example.cc +++ b/examples/energy/energy-model-example.cc @@ -35,7 +35,7 @@ using namespace ns3; -std::string +static inline std::string PrintReceivedPacket (Address& from) { InetSocketAddress iaddr = InetSocketAddress::ConvertFrom (from); diff --git a/examples/routing/manet-routing-compare.cc b/examples/routing/manet-routing-compare.cc --- a/examples/routing/manet-routing-compare.cc +++ b/examples/routing/manet-routing-compare.cc @@ -119,7 +119,7 @@ { } -std::string +static inline std::string PrintReceivedPacket (Ptr socket, Ptr packet) { SocketAddressTag tag; diff --git a/examples/wireless/multirate.cc b/examples/wireless/multirate.cc --- a/examples/wireless/multirate.cc +++ b/examples/wireless/multirate.cc @@ -309,14 +309,14 @@ } } -Vector +static inline Vector GetPosition (Ptr node) { Ptr mobility = node->GetObject (); return mobility->GetPosition (); } -std::string +static inline std::string PrintPosition (Ptr client, Ptr server) { Vector serverPos = GetPosition (server); diff --git a/examples/wireless/wifi-simple-interference.cc b/examples/wireless/wifi-simple-interference.cc --- a/examples/wireless/wifi-simple-interference.cc +++ b/examples/wireless/wifi-simple-interference.cc @@ -96,7 +96,7 @@ using namespace ns3; -std::string PrintReceivedPacket (Ptr socket) +static inline std::string PrintReceivedPacket (Ptr socket) { Address addr; socket->GetSockName (addr); @@ -108,7 +108,7 @@ return oss.str (); } -void ReceivePacket (Ptr socket) +static void ReceivePacket (Ptr socket) { NS_LOG_UNCOND (PrintReceivedPacket (socket)); } diff --git a/src/test/ns3wifi/wifi-interference-test-suite.cc b/src/test/ns3wifi/wifi-interference-test-suite.cc --- a/src/test/ns3wifi/wifi-interference-test-suite.cc +++ b/src/test/ns3wifi/wifi-interference-test-suite.cc @@ -77,7 +77,7 @@ { } -std::string +static inline std::string PrintReceivedPacket (Ptr socket) { Address addr; diff --git a/src/topology-read/model/rocketfuel-topology-reader.cc b/src/topology-read/model/rocketfuel-topology-reader.cc --- a/src/topology-read/model/rocketfuel-topology-reader.cc +++ b/src/topology-read/model/rocketfuel-topology-reader.cc @@ -77,7 +77,7 @@ int nodesNumber = 0; std::map > nodeMap; -void +static inline void PrintNodeInfo (std::string & uid, std::string & loc, bool dns, bool bb, std::vector ::size_type neighListSize, std::string & name, int radius)