Bug 1070

Summary:	csma/ipv6 examples duplicate NS_LOG_COMPONENT_DEFINE
Product:	ns-3	Reporter:	John Abraham <john.abraham.in>
Component:	examples	Assignee:	ns-bugs <ns-bugs>
Status:	RESOLVED FIXED
Severity:	trivial	CC:	jpelkey, ns-bugs, suresh.lalith
Priority:	P5
Version:	pre-release
Hardware:	All
OS:	All

Description John Abraham 2011-03-09 16:27:08 EST

csma-raw-ip-socket.cc uses 
NS_LOG_COMPONENT_DEFINE ("CsmaPacketSocketExample");

which is already used by
csma-packet-socket.cc

Similar case for radvd-two-prefix.cc vs radvd.cc

Comment 1 John Abraham 2011-03-10 16:05:35 EST

Similar case for

wimax-simple.cc vs wimax-ipv4.cc
first.cc vs nix-simple.cc

Comment 2 Josh Pelkey 2011-03-10 16:37:17 EST

(In reply to comment #1)
> Similar case for
> 
> wimax-simple.cc vs wimax-ipv4.cc
> first.cc vs nix-simple.cc

Could you post a patch for this? I think you could change the component defines based on the file name. For example, csma-raw-ip-socket.cc should be CsmaRawIpSocket.

Comment 3 Lalith Suresh 2011-03-11 16:50:50 EST

Fixed and committed.

changeset 6892:dc8533a99c63