Bug 1106

Summary: Remove "CanvasLocation" dependencies in p2p helpers
Product: ns-3 Reporter: John Abraham <john.abraham.in>
Component: helpersAssignee: John Abraham <john.abraham.in>
Status: RESOLVED FIXED    
Severity: enhancement CC: jpelkey, ns-bugs, riley
Priority: P5    
Version: pre-release   
Hardware: All   
OS: All   
Attachments: Removing CanvasLocation dependencies in NetAnim and examples/matrix-topology
Py bindings to be scanned later. Diff of changes in NetAnim and examples/matrix-topology
New patch removing canvas-location.cc and .h
dumbbell using pyViz after changes
dumbbell before changes, using pyviz

Description John Abraham 2011-04-19 09:13:26 EDT
The current p2p helpers depend on "CanvasLocation". However, as other modules such as wireless and pyviz use "MobilityModels" for node-placement, the "CanvasLocation" dependencies can be changed to a dependency on "MobilityModels".
Comment 1 John Abraham 2011-04-19 19:40:55 EDT
Created attachment 1085 [details]
Removing CanvasLocation dependencies in NetAnim and examples/matrix-topology
Comment 2 John Abraham 2011-04-19 19:44:13 EDT
Created attachment 1086 [details]
Py bindings to be scanned later. Diff of changes in NetAnim and examples/matrix-topology
Comment 3 Josh Pelkey 2011-04-21 09:34:15 EDT
This patch looks right to me. Did you test this out with net-anim to make sure the topologies still looked right? Also, you can try it in pyviz now too, and it should pick up on the mobility model and look the same as netanim now! Finally, is there any reason to keep CanvasLocation around any more?
Comment 4 John Abraham 2011-04-21 11:59:20 EDT
Created attachment 1088 [details]
New patch removing canvas-location.cc and .h
Comment 5 John Abraham 2011-04-21 12:02:18 EDT
Created attachment 1089 [details]
dumbbell using pyViz after changes

dumbbell using pyViz after changes
Comment 6 John Abraham 2011-04-21 12:03:28 EDT
Created attachment 1090 [details]
dumbbell before changes, using pyviz