Bugzilla – Full Text Bug Listing |
Summary: | simple-odfm-wimax-phy creates UniformVariable in a critical path | ||
---|---|---|---|
Product: | ns-3 | Reporter: | Claudio <claudio-daniel.freire> |
Component: | wimax | Assignee: | Flavio Kubota <kubota> |
Status: | NEW --- | ||
Severity: | enhancement | CC: | ns-bugs |
Priority: | P5 | ||
Version: | ns-3-dev | ||
Hardware: | All | ||
OS: | All | ||
Attachments: | Mercurial patchset. Import with "hg import <patchfile>" |
Created attachment 1199 [details] Mercurial patchset. Import with "hg import <patchfile>" Just a performance enhancement, with some, yet trivial, impact on simulation results (different RNG sequences used). simple-odfm-wimax-phy creates a UniformVariable (which initializes an RngStream) repeatedly whenever processing packets. It's inefficient, and I suspect it detracts from the RNG quality to be used like this. The attached patch adds a private UniformVariable member that's initialized at creation time, instead, which improves performance (and, I believe, quality of the resulting random stream).