Bugzilla – Full Text Bug Listing |
Summary: | ns-3 should put each module's headers in a separate directory | ||
---|---|---|---|
Product: | ns-3 | Reporter: | Vedran Miletić <vedran> |
Component: | build system | Assignee: | Gustavo J. A. M. Carneiro <gjcarneiro> |
Status: | NEW --- | ||
Severity: | normal | CC: | mathieu.lacage, nicola, ns-bugs, sebastien.deronne |
Priority: | P5 | ||
Version: | pre-release | ||
Hardware: | All | ||
OS: | All |
Description
Vedran Miletić
2012-01-16 15:35:12 EST
I remember Mathieu Lacage used to be pretty much against it in the early days of ns-3. Did that change? I think this is a very visible change and needs to be discussed in the mailing-list in a very clear way. It requires changing all the includes, and the style of ns-3 programming changes slightly. Wheres before you'd include "ns3/whatever" and not care which module defined it, now you need to say in which module the header is found. And the headers file names are namespaced, but the C++ definitions are not, we only have a single ns3 C++ namespace for everything. I am -0 for this change: it doesn't really solve any problem, so why bother. I understand. Would your opinion on it improve if we also suggested introducing namespaces for each module as well? Mathieu's comment is in [2] in my original post: "I think that no one said that they were against more modular headers but I do not think anyone has cycles to spend on this so if you want to make it happen, you need to come up with a concrete proposal that takes into account the comments you got previously about it and that lays out a plan for the necessary migration." (In reply to comment #2) > "I think that no one said that they were against more modular headers > but I do not think anyone has cycles to spend on this so if you want > to make it happen, you need to come up with a concrete proposal that > takes into account the comments you got previously about it and that > lays out a plan for the necessary migration." +1 +1. Any reason why this is pending? I guess this is not so much effort. |