|
Bugzilla – Full Text Bug Listing |
| Summary: | Make RttEstimator available to other modules | ||
|---|---|---|---|
| Product: | ns-3 | Reporter: | Alex Afanasyev <alexander.afanasyev> |
| Component: | internet | Assignee: | Brian Swenson <bswenson3> |
| Status: | PATCH WANTED --- | ||
| Severity: | normal | CC: | daniel.camara, natale.patriciello, ns-bugs, tomh, tommaso.pecorella |
| Priority: | P5 | ||
| Version: | ns-3-dev | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | 1405 | ||
| Bug Blocks: | |||
| Attachments: | Patch fixing the bug | ||
|
Description
Alex Afanasyev
2012-04-18 15:35:50 EDT
I'm neutral with this change. Meaning the pros and cons are balanced. Pros: you're right, it's a nice piece of code and *could* be useful. Cons: the original algorithm was proposed for TCP and (to my best knowledge) is not used in any other protocol. If you can provide a practical example of where it could be reused, I'm more than keen to give a +1 T. (In reply to comment #1) > I'm neutral with this change. Meaning the pros and cons are balanced. > > Pros: you're right, it's a nice piece of code and *could* be useful. > > Cons: the original algorithm was proposed for TCP and (to my best knowledge) is > not used in any other protocol. > > If you can provide a practical example of where it could be reused, I'm more > than keen to give a +1 > > T. I would support moving it to network/utils/ just based on Alex's stated need. Fine by me. +1 Created attachment 1531 [details]
Patch fixing the bug
Ok, the bug is this.
The ObjectBase::ConstructSelf (AttributeConstructionList ()) function will call GetInstanceTypeId, which usually is a virtual function, inherited from Object. The function should call GetTypeId, which is static to the class.
On the other hand, inside the constructor the object is still not fully created, hence its virtual inherited stuff is kinda... strange.
To make a long story short. This will work *only* if the object is actually implementing a GetInstanceTypeId function.
The patch does this and it clarifies the manual about this point.
T.
(In reply to comment #4) > Created attachment 1531 [details] > Patch fixing the bug > > Ok, the bug is this. > > The ObjectBase::ConstructSelf (AttributeConstructionList ()) function will call > GetInstanceTypeId, which usually is a virtual function, inherited from Object. > The function should call GetTypeId, which is static to the class. > > On the other hand, inside the constructor the object is still not fully > created, hence its virtual inherited stuff is kinda... strange. > > To make a long story short. This will work *only* if the object is actually > implementing a GetInstanceTypeId function. > > The patch does this and it clarifies the manual about this point. > > T. Opps, added to the wrong bug... :( Can this bug be closed with the RTT patches provided by Tommaso some times ago? I'm not sure which patch you are referring to. The patch attached to this bug is marked obsolete since it was attached to the wrong bug. Rtt-Estimator.h is in wscript for internet, I believe that got changed when the RttTestCase was created. Prior it was not accessible. The request was to move it to the network module, which has not been done. Its more of a feature suggestion than a bug and the feature hasn't been implemented. I think that the current ns-3-dev version of this could be moved to src/network/utils and that would satisfy the original request. |