Bugzilla – Full Text Bug Listing |
Summary: | int64x64_t double conversions | ||
---|---|---|---|
Product: | ns-3 | Reporter: | Peter Barnes <pdbarnes> |
Component: | core | Assignee: | Peter Barnes <pdbarnes> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ns-bugs, tomh |
Priority: | P5 | ||
Version: | ns-3-dev | ||
Hardware: | PC | ||
OS: | All | ||
See Also: |
https://www.nsnam.org/bugzilla/show_bug.cgi?id=1786 https://www.nsnam.org/bugzilla/show_bug.cgi?id=1505 https://www.nsnam.org/bugzilla/show_bug.cgi?id=1761 |
Description
Peter Barnes
2014-02-14 15:49:45 EST
The test failing on Fedora Core 20, 32 bit, optimized build is global-routing, due to an off-by-one difference in integer to double conversions. The test that is crashing on gcc-4.4.3 is int64x64. Just noting the additional information so that duplicate bugs are not reported. This turns out to expose several issues: - grossly insufficient test coverage - int64x64 implements Q64.64 fixed precision arithmetic, but fractions were mishandled or not even implemented - output of int64x64 was subtly wrong, because the patch for bug 1786 was tested against the buggy int64x64 implementation Pending patch: - implements complete test coverage - handles fractions correctly - fixes int64x64 output (again) Patch r10637 67601c471c22 http://code.nsnam.org/ns-3-dev/rev/67601c471c22 This leaves four tests failing because of deltas of 1 ns in Times, ultimately affecting pcap output. Patch r10638 aa85c4fcd5d7 http://code.nsnam.org/ns-3-dev/rev/aa85c4fcd5d7 Update test reference pcap for: TestSuite devices-mesh-dot11s-regression TestSuite devices-mesh-flame-regression TestSuite routing-aodv-regression TestSuite routing-olsr-regression |