Bug 1902

Summary: m_txPacketTrace defined but not called
Product: ns-3 Reporter: Konstantinos Katsaros <dinos.katsaros>
Component: dsrAssignee: Yufei Cheng <michaelcheng1943>
Status: NEW ---    
Severity: enhancement CC: ns-bugs
Priority: P5    
Version: ns-3-dev   
Hardware: All   
OS: All   
Attachments: Patch for m_txPacketTrace usage in DSR

Description Konstantinos Katsaros 2014-04-22 10:59:47 EDT
This trace source is declared in dsr-routing but not called. It should trace all Tx DSR packets. I guess that is to count the control packets.

.AddTraceSource ("Tx", "Send DSR packet.", MakeTraceSourceAccessor (&DsrRouting::m_txPacketTrace))

A solution (will submit a patch soon) is to call it whenever the DownTargetCallback is called and the packet has a priority DSR_CONTROL_PACKET.
Comment 1 Konstantinos Katsaros 2014-04-22 15:28:52 EDT
Created attachment 1823 [details]
Patch for m_txPacketTrace usage in DSR

The patch triggers m_txPacketTrace every time the m_downTarget callback is triggered with DSR_DATA_PACKET and introduces another trace source for the DSR_CONTROL_PACKET in similar situations.