Bug 1922

Summary: GetSsid should not be fatal
Product: ns-3 Reporter: Scott Carpenter <scarpen>
Component: wave moduleAssignee: Daniel L. <nikkipui>
Status: RESOLVED FIXED    
Severity: trivial CC: ns-bugs, tommaso.pecorella
Priority: P5    
Version: ns-3-dev   
Hardware: All   
OS: All   

Description Scott Carpenter 2014-06-01 08:53:45 EDT
I propose the following simple patch:

in src/wave/model/ocb-wifi-mac.cc

128c128
<   NS_FATAL_ERROR ("in OCB mode we should not call GetSsid");
---
>   NS_LOG_WARN ("in OCB mode we should not call GetSsid");

Issue:
While it is true that the SSID should not be needed for WAVE devices (should not need to call GetSsid()), this does not need to be fatal.  Specifically, when saving a Wifi-enabled simulation using config-store, all attributes will be attempted to be read and written through config store, and the same for then "restoring" the configuration using config-store.  This winds up calling GetSsid().  If the method is left as executing an NS_FATAL_ERROR, then I cannot save WAVE simulations using config-store.
Comment 1 Tommaso Pecorella 2014-06-01 10:10:08 EDT
+1
Comment 2 Tommaso Pecorella 2014-06-06 17:33:13 EDT
changeset 10804	6842aac2d3ea