Bug 2922

Summary: Get() methods should return std::size_t
Product: ns-3 Reporter: sebastien.deronne
Component: generalAssignee: sebastien.deronne
Status: PATCH WANTED ---    
Severity: enhancement    
Priority: P3    
Version: unspecified   
Hardware: All   
OS: All   

Description sebastien.deronne 2018-05-31 17:51:04 EDT
As discussed on the developers list, we agreed to move returned type of Get() methods to std::size_t.


I am going to push very shortly a patch for:

channel.h: virtual uint32_t GetNDevices (void) const = 0;

and corresponding GetDevice() methods, and all subclasses as well.


For API consistency, we also have these to be replaced:

channel-list.h: static uint32_t GetNChannels (void);
net-device.h: virtual Ptr<Node> GetNode (void) const = 0;
node.h: uint32_t GetNDevices (void) const;
node.h: uint32_t GetNApplications (void) const;
node-list.h: static uint32_t GetNNodes (void);
application-container.h: uint32_t GetN (void) const;
net-device-container.h: uint32_t GetN (void) const;
node-container.h: uint32_t GetN (void) const;
queue-disc.h: uint32_t GetNInternalQueues (void) const;
queue-disc.h: uint32_t GetNPacketFilters (void) const;
queue-disc.h: uint32_t GetNQueueDiscClasses (void) const;
Comment 1 sebastien.deronne 2018-05-31 18:14:58 EDT
Change for Channel has been pushed in changeset 13611:547cdffdcdd0