Bugzilla – Full Text Bug Listing |
Summary: | Where is tcp-echo.cc? | ||
---|---|---|---|
Product: | ns-3 | Reporter: | Craig Dowell <craigdo> |
Component: | documentation | Assignee: | natale.patriciello |
Status: | PATCH PENDING --- | ||
Severity: | normal | CC: | bswenson3, frankhelbert82, natale.patriciello, tomh |
Priority: | P5 | ||
Version: | pre-release | ||
Hardware: | All | ||
OS: | All | ||
Attachments: |
Patch that adds tcp-echo helper, testsuit, example, and so on
The same patch above with Ipv6 support and AddressPrinter class TcpEcho classes (modified) |
Description
Craig Dowell
2008-12-22 13:42:33 EST
Created attachment 1321 [details]
Patch that adds tcp-echo helper, testsuit, example, and so on
We've done a helper.
We added some files under src/applications/model:
tcp-echo-client.cc
tcp-echo-client.h
tcp-echo-server.cc
tcp-echo-server.h
Under src/applications/helper:
tcp-echo-helper.cc
tcp-echo-helper.h
Under src/applications/test:
tcp-echo-test-suite.cc
Under examples/tcp:
tcp-echo-example.cc
We really appreciate any suggestions to improve the code.
Everything seems to run smooth.
Next step should be writing some pages to the tutorial, but we like some feedback for now.
Thanks,
Nice job. Could you please post it to retveld (http://codereview.appspot.com/) so it's easier to read and comment ? Also, we do have an incoming big patch about IPv6, TCP and UDP (see here: http://codereview.appspot.com/5417048/). I don't know if it will be merged earlier than this one, but: - if the IPv6 patch is pushed earlier, please update your code accordingly so to support IPv6 addresses - if tcp-echo is pushed earlier, please be ready to ... see above. Ken did a great job updating all the existing examples, we don't want to give him more work, isn't it ? Cheers, Tommaso Created attachment 1333 [details]
The same patch above with Ipv6 support and AddressPrinter class
Dear all, Same patch ready for the incoming big patch about IPv6, TCP and UDP (http://codereview.appspot.com/5417048/). Added some code to files address-utils.cc and address-utils.h to print Ipv4 and Ipv6 address easily (in human readable form), without the need to test what kind of address they are. Simple to use, just cast the address to AddressPrinter and ready. Example: NS_LOG_INFO ("Received " << packet->GetSize () << " bytes from " << (AddressPrinter)from); It doesn't matter of what type is the variable "from", if it is Ipv4Address, Ipv6Address, Address, InetSocketAddress, Inet6SocketAddress, it will print fine. I think it will save many if's from source. Cheers, Frank Now on http://codereview.appspot.com/5654053/ also. (In reply to comment #4) > Dear all, > > Same patch ready for the incoming big patch about IPv6, TCP and UDP > (http://codereview.appspot.com/5417048/). > > Added some code to files address-utils.cc and address-utils.h to print Ipv4 and > Ipv6 address easily (in human readable form), without the need to test what > kind of address they are. Simple to use, just cast the address to > AddressPrinter and ready. > > Example: > NS_LOG_INFO ("Received " << packet->GetSize () << " bytes from " << > (AddressPrinter)from); > > It doesn't matter of what type is the variable "from", if it is Ipv4Address, > Ipv6Address, Address, InetSocketAddress, Inet6SocketAddress, it will print > fine. > > I think it will save many if's from source. > > Cheers, > Frank Created attachment 1371 [details] TcpEcho classes (modified) Same as http://codereview.appspot.com/5654053/ but with the following changes: 1) my own comments fixed. 2) Copyright (mostly) fixed. 3) stripped out AddressPrinter class (I think we need a better solution). T. Any reason not to commit this for upcoming release build? (In reply to comment #7) > Any reason not to commit this for upcoming release build? It is waiting for Frank to respond to Tommaso's comments (or to accept Tommaso's changes). Hi, have this some interest ? If yes, I will look into code, if not, close it as invalid (and link this to some wiki page for students' idea) |