Bug 1566 – WiFi SNR tag improvements

Bug 1566 - WiFi SNR tag improvements


Summary:	WiFi SNR tag improvements

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	wifi
Version:	pre-release
Hardware:	PC Linux

Importance:	P5 enhancement
Assigned To:	Nicola Baldo

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-01-14 00:20 EST by Tom Henderson
Modified:	2013-07-12 14:56 EDT (History)
CC List:	4 users (show)

See Also:

Attachments
patch existing code (2.84 KB, text/plain) 2013-01-14 00:20 EST, Tom Henderson	Details
snr-tag header (1.72 KB, text/x-chdr) 2013-01-14 00:21 EST, Tom Henderson	Details
snr-tag implementation (2.00 KB, text/x-c++src) 2013-01-14 00:21 EST, Tom Henderson	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tom Henderson 2013-01-14 00:20:53 EST

Created attachment 1496 [details]
patch existing code

Copying over from ns-3-reviews, so we don't lose track of this.

Hi all,

I have noticed that the SNR tag is still embedded in mac-low.cc which makes it unusable for others.
Therefore, I have created this small patch to clean it a bit. This is based on the code in mac-low and the qos-tag.

Any comments are welcome. I will provide also some scenario examples to use it. 

Regards,
Konstantinos

Comment 1 Tom Henderson 2013-01-14 00:21:25 EST

Created attachment 1497 [details]
snr-tag header

Comment 2 Tom Henderson 2013-01-14 00:21:49 EST

Created attachment 1498 [details]
snr-tag implementation

Comment 3 Daniel L. 2013-02-10 13:47:34 EST

changeset: 9234:310d371059d5

Comment 4 Jonathan Ling 2013-07-12 14:56:55 EDT

Konstantions,
Thanks!  Perhaps to mention the current usage is as a side-channel to get the received SNR to the sending node, but that we would also like to reuse tag upward.  For example: in mac-low.cc

rxPacket:
  WifiMacTrailer fcs;
  packet->RemoveTrailer (fcs);
  
  SnrTag tag; // to make receive SNR available at upper layers
  if (packet->PeekPacketTag(tag) == true)
    {
      packet->RemovePacketTag(tag);
    }
  tag.Set (rxSnr);  
 packet->AddPacketTag (tag);