Bug 1670 - bake reports it is downloading pyviz-prerequisites
bake reports it is downloading pyviz-prerequisites
Status: REOPENED
Product: bake
Classification: Unclassified
Component: bake
unspecified
All All
: P5 normal
Assigned To: Daniel Camara
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-04 18:48 EDT by Tom Henderson
Modified: 2013-05-06 10:20 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Henderson 2013-05-04 18:48:05 EDT

    
Comment 1 Tom Henderson 2013-05-04 18:50:17 EDT
Bake, configured for ns-3.17, reports that it is downloading pyviz-prerequisites:

 >> Downloading pyviz-prerequisites - OK

However, this is just a meta-module with no actual source code or items to download: 

   <module name="pyviz-prerequisites">
      <source type="none">
      </source>
      <depends_on name="python-dev" optional="True"/>
      <depends_on name="pygraphviz" optional="True"/>
      <depends_on name="pygoocanvas" optional="True"/>
      <build type="none" objdir="no">
      </build>
    </module>


Should a source type="none" type of module report that it is downloading, or should the message be suppressed for source type="none"?
Comment 2 Daniel Camara 2013-05-06 01:56:39 EDT
This is not the way it should be done. The prerequisites should be attached to the module they are needed to...  pyviz, I would guess here.  In genneral a module should be downloaded and compiled. The type none is not intended to be a wild card for putting things together. 

The download/build message is a way to inform users what is being treated by Bake more than anything else, if there is a module called pyviz-prerequisites I guess it  is important for the user to be informed it is being treated.  It could be possible to remove the message for none, but it is not for what none was created for.
Comment 3 Daniel Camara 2013-05-06 03:13:47 EDT
Download message removed for download none:
changeset 253
Comment 4 Tom Henderson 2013-05-06 10:20:00 EDT
(In reply to comment #2)
> This is not the way it should be done. The prerequisites should be attached to
> the module they are needed to...  pyviz, I would guess here.  In genneral a
> module should be downloaded and compiled. The type none is not intended to be a
> wild card for putting things together. 
> 

(reopening because there is a lingering issue)

How do you think it should be handled in this case, though?  pyviz is not separated from ns-3 but part of it.  

There are a few of these optional packages for ns-3 (not already being covered in bakeconf.xml).

libxml2-dev
sqlite3
gtk

I guess we can enumerate all of the pyviz-prerequisites directly into ns-3.17 and ns-3-dev, and add also libxml2-dev, sqlite, ?  My main concern with this is that we do a good job with good error/warning messages, since the new user downloading ns-3 this way may be scared off.