Bug 1785 – Need destination and source mac addresses in MAC trace hooks

Bug 1785 - Need destination and source mac addresses in MAC trace hooks


Summary:	Need destination and source mac addresses in MAC trace hooks

Status:	RESOLVED MOVED

Product:	ns-3
Classification:	Unclassified
Component:	wifi
Version:	ns-3-dev
Hardware:	All All

Importance:	P5 enhancement
Assigned To:	sebastien.deronne

URL:
Keywords:

Depends on:
Blocks:	1645
	Show dependency tree / graph

Reported:	2013-10-26 15:24 EDT by Gustavo J. A. M. Carneiro
Modified:	2020-04-12 09:19 EDT (History)
CC List:	2 users (show)

See Also:

Attachments
patch (26.13 KB, patch) 2013-10-26 15:24 EDT, Gustavo J. A. M. Carneiro	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gustavo J. A. M. Carneiro 2013-10-26 15:24:47 EDT

Created attachment 1688 [details]
patch

For fixing bug 1645, pyviz needs access to the addresses of the packet in MacTx and MacRx.  For completeness, the attached patch adds destination and source addresses to all the trace hooks, where applicable.

Comment 1 Daniel L. 2013-10-29 09:41:44 EDT

Hi Gustavo,

Thanks for the patch. I looked through it and the code is good. However, I'm not sure about the meaning of "source" and "destination" for NotifyXXX. Do you want to them to mean "transmitter and receiver" or "original source and destination"? I just want to check that they are correct.

Thanks,
Daniel

Comment 2 Gustavo J. A. M. Carneiro 2013-10-29 09:47:18 EDT

Hello.  What pyviz needs, at least, is the transmitter and receiver MAC stations.  If an AP is retransmitting a MAC frame from STA1 to STA2, I would like destination to be STA2.macaddr and source to be STA1.macaddr, even though the AP would be the actual transmitter.

Comment 3 Daniel L. 2013-10-29 10:05:16 EDT

Hi,

I see why you used GetAddr3() in some places.

One thing that I'm not sure is that I think most people would expect these kind of traces to show the immediate sender and receiver. (i.e. with AP, that would show AP address).

Comment 4 Gustavo J. A. M. Carneiro 2013-10-29 10:16:11 EDT

Hm.. ideally it would probably be better to just have the WifiMacHeader as parameter, but I'm not sure that is easy to obtain in all places...

Comment 5 sebastien.deronne 2020-04-12 09:19:07 EDT

Moved to https://gitlab.com/nsnam/ns-3-dev/-/issues/175