Bug 1898 - click version needed for ns-3.20
click version needed for ns-3.20
Status: RESOLVED FIXED
Product: ns-3
Classification: Unclassified
Component: click
pre-release
PC Linux
: P5 normal
Assigned To: Lalith Suresh
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-13 16:04 EDT by Tom Henderson
Modified: 2014-04-24 12:46 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Henderson 2014-04-13 16:04:38 EDT
The current tip of the github click repo is not compiling as configured for ns-3.

On a Fedora Core 19 system (which can build the click for ns-3.17) I get:

  CXX ../elements/wifi/radiotapencap.cc
../elements/wifi/radiotapencap.cc: In member function ‘virtual Packet* RadiotapEncap::simple_action(Packet*)’:
../elements/wifi/radiotapencap.cc:89:113: error: ‘IEEE80211_RADIOTAP_DBM_TX_FLAGS’ was not declared in this scope
    crh->wt_ihdr.it_present = cpu_to_le32(CLICK_RADIOTAP_PRESENT);

                                 ^
make[1]: *** [radiotapencap.o] Error 1


This is after the configure step of:

$ ./configure --disable-linuxmodule --enable-nsclick --enable-wifi


Please suggest a git changeset that we should use for ns-3.20.  We can continue to use the one from ns-3.17 if you suggest:
056d2c0a75baaf196fca2622ff9eb80f28038bc0

but it is about a year old now.
Comment 1 Lalith Suresh 2014-04-14 16:28:15 EDT
(In reply to Tom Henderson from comment #0)
> The current tip of the github click repo is not compiling as configured for
> ns-3.
> 
> On a Fedora Core 19 system (which can build the click for ns-3.17) I get:
> 
>   CXX ../elements/wifi/radiotapencap.cc
> ../elements/wifi/radiotapencap.cc: In member function ‘virtual Packet*
> RadiotapEncap::simple_action(Packet*)’:
> ../elements/wifi/radiotapencap.cc:89:113: error:
> ‘IEEE80211_RADIOTAP_DBM_TX_FLAGS’ was not declared in this scope
>     crh->wt_ihdr.it_present = cpu_to_le32(CLICK_RADIOTAP_PRESENT);
> 
>                                  ^
> make[1]: *** [radiotapencap.o] Error 1
> 
> 
> This is after the configure step of:
> 
> $ ./configure --disable-linuxmodule --enable-nsclick --enable-wifi
> 
> 
> Please suggest a git changeset that we should use for ns-3.20.  We can
> continue to use the one from ns-3.17 if you suggest:
> 056d2c0a75baaf196fca2622ff9eb80f28038bc0
> 
> but it is about a year old now.


I'm unable to reproduce this on my Ubuntu box. Here's the environment I'm using and the git commit for Click.  

$: g++ --version
g++ (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3
Copyright (C) 2011 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

$: uname -a
Linux irule 3.8.0-31-generic #46~precise1-Ubuntu SMP Wed Sep 11 18:21:16 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux


$: git log -1
commit 50753388c535f0860e60e274c255586eefc9ab94
Author: Eddie Kohler <ekohler@gmail.com>
Date:   Thu Apr 10 07:24:54 2014 -0400

    testie: Support commands broken over several lines by &&/||.


Can you tell me which Click changeset you're using?
Comment 2 Tom Henderson 2014-04-15 02:00:50 EDT
> 
> $: git log -1
> commit 50753388c535f0860e60e274c255586eefc9ab94
> Author: Eddie Kohler <ekohler@gmail.com>
> Date:   Thu Apr 10 07:24:54 2014 -0400
> 
>     testie: Support commands broken over several lines by &&/||.
> 
> 
> Can you tell me which Click changeset you're using?

The same one, on a Fedora Core 19 system (havent tested on other systems yet).

Could it possibly be a dependency on a version of radiotap that is not yet ubiquitous?  It is failing to find this constant defined:  IEEE80211_RADIOTAP_DBM_TX_FLAGS
Comment 3 Lalith Suresh 2014-04-22 16:55:26 EDT
Hi Tom,

(In reply to Tom Henderson from comment #2)
> > 
> > $: git log -1
> > commit 50753388c535f0860e60e274c255586eefc9ab94
> > Author: Eddie Kohler <ekohler@gmail.com>
> > Date:   Thu Apr 10 07:24:54 2014 -0400
> > 
> >     testie: Support commands broken over several lines by &&/||.
> > 
> > 
> > Can you tell me which Click changeset you're using?
> 
> The same one, on a Fedora Core 19 system (havent tested on other systems
> yet).
> 
> Could it possibly be a dependency on a version of radiotap that is not yet
> ubiquitous?  It is failing to find this constant defined: 
> IEEE80211_RADIOTAP_DBM_TX_FLAGS

Can you please retry with Click changeset 0ac37dc30b0386f3c3d2d990f3d855b8887b4a13 ?

The offending line has been fixed as of that changeset, and I've tested it against current ns-3-dev.
Comment 4 Tom Henderson 2014-04-24 12:46:07 EDT
agreed, I'll use that for ns-3.20.