Bug 1902 - m_txPacketTrace defined but not called
m_txPacketTrace defined but not called
Status: NEW
Product: ns-3
Classification: Unclassified
Component: dsr
All All
: P5 enhancement
Assigned To: Yufei Cheng
Depends on:
  Show dependency treegraph
Reported: 2014-04-22 10:59 EDT by Konstantinos Katsaros
Modified: 2014-04-22 15:28 EDT (History)
1 user (show)

See Also:

Patch for m_txPacketTrace usage in DSR (3.85 KB, patch)
2014-04-22 15:28 EDT, Konstantinos Katsaros
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantinos Katsaros 2014-04-22 10:59:47 EDT
This trace source is declared in dsr-routing but not called. It should trace all Tx DSR packets. I guess that is to count the control packets.

.AddTraceSource ("Tx", "Send DSR packet.", MakeTraceSourceAccessor (&DsrRouting::m_txPacketTrace))

A solution (will submit a patch soon) is to call it whenever the DownTargetCallback is called and the packet has a priority DSR_CONTROL_PACKET.
Comment 1 Konstantinos Katsaros 2014-04-22 15:28:52 EDT
Created attachment 1823 [details]
Patch for m_txPacketTrace usage in DSR

The patch triggers m_txPacketTrace every time the m_downTarget callback is triggered with DSR_DATA_PACKET and introduces another trace source for the DSR_CONTROL_PACKET in similar situations.