Bug 2256 – TcpTxBuffer should be able to tell BytesInFlight

Bug 2256 - TcpTxBuffer should be able to tell BytesInFlight


Summary:	TcpTxBuffer should be able to tell BytesInFlight

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	tcp
Version:	pre-release
Hardware:	PC Linux

Importance:	P5 critical
Assigned To:	natale.patriciello

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2016-01-09 12:41 EST by natale.patriciello
Modified:	2017-02-03 08:04 EST (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description natale.patriciello 2016-01-09 12:41:22 EST

Forked from bug 2247.

Some history:

TcpTxBuffer returns chunks of (previously stored) data, and can do that until the data is discarded through a call to DiscardUpTo. Until now, TcpSocketBase was the class which dealed with sequence number calculation. However, TcpTxBuffer could help in telling the amount of bytes in flight, e.g. the bytes requested by TcpSocketBase, but not yet discarded.

Comment 1 natale.patriciello 2016-01-09 12:43:05 EST

The proposed patch is here:

https://github.com/kronat/ns-3-dev-git/commit/f8e8b063d1e76b5d532df9d7a84fc591ea6198b7

and this is the test case: 

https://github.com/kronat/ns-3-dev-git/commit/e7f2ca469357c492ff2811d953c4fb4b122eb1e0

This allow to use, in the future, the TcpTxBuffer as a scoreboard for saving important information (as packet status, or SACK information).

Please, test if you can!

Nat

Comment 2 natale.patriciello 2016-05-22 16:20:49 EDT

Updated: 

https://codereview.appspot.com/299130043/

Comment 3 natale.patriciello 2017-02-03 08:04:37 EST

fixed in 12634:93a74b47e438