Bug 2299 - code review: UAN WOSS integration
code review: UAN WOSS integration
Status: RESOLVED FIXED
Product: ns-3
Classification: Unclassified
Component: uan
unspecified
All All
: P5 enhancement
Assigned To: Federico Guerra
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2016-02-16 17:33 EST by Tom Henderson
Modified: 2020-01-13 15:57 EST (History)
1 user (show)

See Also:


Attachments
missing function has been implemented (1.17 KB, patch)
2018-07-06 04:36 EDT, Federico Guerra
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Henderson 2016-02-16 17:33:55 EST
Federico has been interested in integrating this with ns-3; additional reviewers are sought:

https://codereview.appspot.com/14677043/
Comment 1 Tom Henderson 2017-08-17 11:32:19 EDT
The ns-3 patches from this codereview are merged in changeset 13044:e0b228ec3c44.

The remaining 'woss' code is intended for an ns-3 contributed module; it will be maintained at:  https://github.com/MetalKnight/woss

I'll leave this open until the ns-3 module is broadly available.  Future woss module comments can be addressed at the above github issue tracker.
Comment 2 Federico Guerra 2017-08-17 12:41:27 EDT
correct repo URL

https://github.com/MetalKnight/woss-ns3
Comment 3 Federico Guerra 2018-07-06 04:08:01 EDT
UAN modifications have not been properly merged in NS3 repo.

This function
https://codereview.appspot.com/14677043/patch/163001/173012

https://codereview.appspot.com/14677043/patch/163001/173011

is missing.

I will provide a patch asap for Tom to merge
Comment 4 Federico Guerra 2018-07-06 04:36:42 EDT
Created attachment 3122 [details]
missing function has been implemented

proposed patch attached.
I haven't have the time to compile and test it yet.
I will give you the final verdict as soon as possible.
Comment 5 Tom Henderson 2018-07-07 11:03:33 EDT
(In reply to Federico Guerra from comment #4)
> Created attachment 3122 [details]
> missing function has been implemented
> 
> proposed patch attached.
> I haven't have the time to compile and test it yet.
> I will give you the final verdict as soon as possible.


OK, will wait for your final patch or confirmation.
Comment 6 Federico Guerra 2018-07-07 14:00:18 EDT
Tom,
patch is working you can merge it whenever you like.

thanks

Federico
Comment 7 Tom Henderson 2018-07-14 19:06:43 EDT
Additional patch merged in commit 13689:f7c7da2c972f

The remaining 'woss' code is intended for an ns-3 contributed module; it will be maintained at:  https://github.com/MetalKnight/woss

I'll leave this open in 'patch pending' state until the ns-3 module is broadly available.  Future woss module comments can be addressed at the above github issue tracker.