Bugzilla – Bug 2344
Attribute names can't have spaces
Last modified: 2016-09-10 17:32:24 EDT
The Attributes of AparfWifiManager, "SuccessThreshold 1" & "SuccessThreshold 2", contains space in the attributes name. So when users use ConfigStore to input a configure file which includes these two attributes will encounter an error caused by that totally unnecessary space. The error is introduced in RawTextConfigLoad::Strip() the statements "NS_ASSERT (start == 0);". So it is hard to define whether the error is caused by AparfWifiManager or ConfigStore. But I suggest to correct the Attributes and also set a restriction when defining the Attributes as well.
As further discovered, the attributes set for AparfWifiManager are not in a good manner. A lot of them contains space. Please help to correct these error
Created attachment 2350 [details] patch to remove spaces
It could be perhaps fixed in two steps, as suggested above: 1) remove spaces (patch attached) 2) add some support in the core module to disallow spaces in attribute names
I suggest you push this patch, it should indeed be forbidden to used spaces in attributes name.
(In reply to sebastien.deronne from comment #4) > I suggest you push this patch, it should indeed be forbidden to used spaces > in attributes name. I decided to hold it until post-release so that bug 2149 (deprecation of renamed attributes) could be done. I marked bug 2149 as a dependency.
Created attachment 2394 [details] Remove spaces and adapt test I also modify the test case which uses these attributes.
Created attachment 2513 [details] Patch to check for spaces in attribute names
Created attachment 2535 [details] Fix attribute names with spaces This fixes attribute names with spaces: src/internet/model/ipv6-extension.cc src/traffic-control/model/fq-codel-queue-disc.cc src/wifi/model/ampdu-tag.cc src/wifi/model/aparf-wifi-manager.cc src/wifi/test/power-rate-adaptation-test.cc This includes everything from patch 2394, and new attributes introduced since then
Created attachment 2536 [details] Fix attribute names with spaces (Whoops, previous patch included patch 2513 which is the actual checker.) Fix attribute names with spaces This fixes attribute names with spaces: src/internet/model/ipv6-extension.cc src/traffic-control/model/fq-codel-queue-disc.cc src/wifi/model/ampdu-tag.cc src/wifi/model/aparf-wifi-manager.cc src/wifi/test/power-rate-adaptation-test.cc This includes everything from patch 2394, and new attributes introduced since then
pushed in 12315:8c4420df0d19 and 12316:9677c1b23cc9