Bug 2405 – PHY-MAC interface improvement: EndTx event should be added to UanPhyListener class

Bug 2405 - PHY-MAC interface improvement: EndTx event should be added to UanPhyListener class


Summary:	PHY-MAC interface improvement: EndTx event should be added to UanPhyListener ...

Status:	PATCH PENDING

Product:	ns-3
Classification:	Unclassified
Component:	uan
Version:	ns-3.25
Hardware:	All All

Importance:	P5 enhancement
Assigned To:	Federico Guerra

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2016-05-08 04:11 EDT by Federico Guerra
Modified:	2018-03-27 05:35 EDT (History)
CC List:	3 users (show)

See Also:

Attachments
Patch candidate 00 (9.12 KB, patch) 2018-03-09 09:51 EST, Federico Guerra	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Federico Guerra 2016-05-08 04:11:14 EDT

Currently
there is no mandatory tx end event from PHY to MAC.
This is awkward, since it forces the MAC to use an internal timer to mimic the
EndTx of the lower PHY.
The correct solution would be to ensure that the PHY would always notify the MAC
in case of tx completed or dropped due to energy drained.

Comment 1 Hossam Khader 2018-03-05 16:38:09 EST

Hi Federico,

Do you already have a patch for this? Let me know if you need help with this?

Comment 2 Federico Guerra 2018-03-09 09:51:46 EST

Created attachment 3085 [details]
Patch candidate 00

Hi Hossam, 
I'm finally feeling a little better.
I've attached a first patch proposal.

1) Tx End event added to UanPhyListener class
2) MacCw modified accordingly. This requires a thorough check, since I haven't test it thoroughly, the logic should be ok though.

Let me know what you think.

Federico

Comment 3 Federico Guerra 2018-03-09 09:53:33 EST

modified files have been decrustified, hence the many indentation fix/changes.

Comment 4 Tom Henderson 2018-03-09 11:59:57 EST

(In reply to Federico Guerra from comment #3)
> modified files have been decrustified, hence the many indentation
> fix/changes.

Hossam and Federico, do you want to slip this into the ns-3.28 release (is it ready, in your opinion)?

Comment 5 Federico Guerra 2018-03-27 05:35:22 EDT

Hi Hossam,
do you have any comment?
thanks

Federico