Bug 2446 – Comma instead of pipe in Attributes

Bug 2446 - Comma instead of pipe in Attributes


Summary:	Comma instead of pipe in Attributes

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	traffic-control
Version:	ns-3-dev
Hardware:	All All

Importance:	P5 trivial
Assigned To:	Stefano Avallone

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2016-06-22 17:54 EDT by Tommaso Pecorella
Modified:	2016-06-23 17:59 EDT (History)
CC List:	2 users (show)

See Also:	2447

Attachments
fix (3.28 KB, patch) 2016-06-22 17:54 EDT, Tommaso Pecorella	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tommaso Pecorella 2016-06-22 17:54:09 EDT

Created attachment 2477 [details]
fix

In the traffic control examples it is used a wrong syntax, e.g.:
clientHelper.SetAttribute ("OnTime", StringValue ("ns3::UniformRandomVariable[Min=0.,Max=1.]"));

The correct field separator is |, not a comma.

It is worth noticing that also the attribute-test-suite contains the very same mistake.
Lucky enough, the call was setting the attribute value to its default value.

As a side note... is this mentioned in the documentation ?

Comment 1 Tom Henderson 2016-06-22 20:53:12 EDT

see also a similar problem with:

examples/tcp/tcp-nsc-lfn.cc:103

Comment 2 Stefano Avallone 2016-06-23 09:31:33 EDT

Thanks for spotting these mistakes. Please go ahead and commit the fix, thanks!

Comment 3 Tommaso Pecorella 2016-06-23 17:59:34 EDT

pushet in changeset 12168:b7d315126827