Bugzilla – Bug 2509
Pyviz doesn't respond to Simulator::Stop ()
Last modified: 2017-03-23 03:53:24 EDT
To reproduce, run Pyviz on a program that has scheduled Simulator::Stop (); it continues beyond that time.
Created attachment 2811 [details] Attempt to stop simulation at given stop time Recently, I came across this problem when I was using Simulator::Stop (<time>). The problem seems to be happening because in the current implementation, Stop of VisualSimulatorImpl just affects the loop in Run () of DefaultSimulator and even when that loop terminates due to m_stop being true, the while loop from run of SimulationThread calls it in the next iteration making m_stop false again. I am attaching a patch which notifies the SimulationThread of the stop time. The current patch will work only when the stop time is an integer second. Also, once the given time is over the PyViz has to be still closed manually (it will stop at the simulation time but the window does not exit implicitly). If the approach looks fine, I can correct those. Thanks, Ankit
(In reply to adadeepak8 from comment #1) > Created attachment 2811 [details] > Attempt to stop simulation at given stop time > > Recently, I came across this problem when I was using Simulator::Stop > (<time>). The problem seems to be happening because in the current > implementation, Stop of VisualSimulatorImpl just affects the loop in Run () > of DefaultSimulator and even when that loop terminates due to m_stop being > true, the while loop from run of SimulationThread calls it in the next > iteration making m_stop false again. > > I am attaching a patch which notifies the SimulationThread of the stop time. > The current patch will work only when the stop time is an integer second. Rather than maintain m_stopTime as an integer or double, I suggest to try to make it an ns3::Time object, and then use std::ostringstream when you need to convert it to string (e.g. ostringstream str; str << m_stopTime;) > Also, once the given time is over the PyViz has to be still closed manually > (it will stop at the simulation time but the window does not exit > implicitly). If the approach looks fine, I can correct those. > OK, I suggest to try for a final patch.
Created attachment 2812 [details] Using Time for stop time I have changed the data type of m_stopTime to Time.