Bugzilla – Bug 2640
Use default gains of 0 dB
Last modified: 2017-01-29 16:02:43 EST
Created attachment 2766 [details] Set default gains to 0 dB Default TX and RX gains are defined to 1 dB for no real reason. I suggest to set the default value to 0 dB. 3 tests are failing though: devices-mesh-dot11s-regression devices-mesh-flame-regression routing-aodv-regression There are two proposed solutions: - either we rescan pcap files; - or we force gains to be 1 dB in those tests.
> > There are two proposed solutions: > - either we rescan pcap files; > - or we force gains to be 1 dB in those tests. IMO, I support the change, but request also that CHANGES.html call out this change in model behavior. As for pcap files, they should go away anyway in favor of behavioral tests, so to make progress on this now, I would support a local change to the test to preserve 1 dB (and mark that this configuration should go away in future revision to the test); actually I would suggest to leave this bug open to remove the 1 dB from the tests.
(In reply to Tom Henderson from comment #1) > > > > There are two proposed solutions: > > - either we rescan pcap files; > > - or we force gains to be 1 dB in those tests. > > > IMO, I support the change, but request also that CHANGES.html call out this > change in model behavior. > > As for pcap files, they should go away anyway in favor of behavioral tests, > so to make progress on this now, I would support a local change to the test > to preserve 1 dB (and mark that this configuration should go away in future > revision to the test); actually I would suggest to leave this bug open to > remove the 1 dB from the tests. Is it not better to open a thread per module to get rid of those pcap-based tests?
(In reply to sebastien.deronne from comment #2) > (In reply to Tom Henderson from comment #1) > > > > > > There are two proposed solutions: > > > - either we rescan pcap files; > > > - or we force gains to be 1 dB in those tests. > > > > > > IMO, I support the change, but request also that CHANGES.html call out this > > change in model behavior. > > > > As for pcap files, they should go away anyway in favor of behavioral tests, > > so to make progress on this now, I would support a local change to the test > > to preserve 1 dB (and mark that this configuration should go away in future > > revision to the test); actually I would suggest to leave this bug open to > > remove the 1 dB from the tests. > > Is it not better to open a thread per module to get rid of those pcap-based > tests? It does not make a difference to me; feel free to do so.
OK, I will update CHANGES.html and update tests scripts.
changeset 12589:5608f5d3d604