Bug 2754 – Incorrect arguments are passed Asn1Header::SerializeInteger

Bug 2754 - Incorrect arguments are passed Asn1Header::SerializeInteger


Summary:	Incorrect arguments are passed Asn1Header::SerializeInteger

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	lte
Version:	ns-3-dev
Hardware:	All All

Importance:	P3 major
Assigned To:	Manuel Requena

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2017-06-13 10:23 EDT by Alexander Krotov
Modified:	2018-02-21 10:36 EST (History)
CC List:	3 users (show)

See Also:

Attachments
Patch that adds assertion (945 bytes, patch) 2017-06-13 10:23 EDT, Alexander Krotov	Details \| Diff
Fix some related bugs (1.59 KB, patch) 2017-06-13 10:54 EDT, Alexander Krotov	Details \| Diff
Patch for ASN.1 encoding of RRC messages (14.37 KB, patch) 2018-02-21 10:21 EST, Manuel Requena	Details \| Diff
Show Obsolete (2) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alexander Krotov 2017-06-13 10:23:59 EDT

Created attachment 2870 [details]
Patch that adds assertion

Adding assert (nmin <= n && n <= nmax) to Asn1Header::SerializeInteger causes a lot of tests and examples, maybe even all of them which use LteRrcProtocolReal, to crash.

Comment 1 Alexander Krotov 2017-06-13 10:54:36 EDT

Created attachment 2871 [details]
Fix some related bugs

Here is a patch that fixes some of the bugs but crashes still remain.

lte-mimo crashes because m_rrcTransactionIdentifier is 4, for example

Comment 2 Manuel Requena 2018-02-21 10:21:00 EST

Created attachment 3055 [details]
Patch for ASN.1 encoding of RRC messages

Following patch solves all ASN.1 encoding problems.
It also includes the ASSERT and partial patch by Alexander.

Comment 3 Manuel Requena 2018-02-21 10:36:31 EST

patch commit in changeset:   13300:9c62f5c32658