Bug 2844 - LteHelper API consistency
LteHelper API consistency
Status: NEEDINFO
Product: ns-3
Classification: Unclassified
Component: lte
ns-3.27
All All
: P3 normal
Assigned To: Biljana Bojović
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2018-01-04 17:03 EST by Tom Henderson
Modified: 2018-01-04 17:25 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Henderson 2018-01-04 17:03:06 EST
The below commit:

changeset:   12985:9ad6ef8d4ec3
user:        Alexander Krotov <krotov@iitp.ru>
date:        Wed Jun 07 15:41:01 2017 +0300
summary:     lte: Make PathlossModel attribute a TypeId instead of String

introduced some API inconsistency in LteHelper-- a number of other TypeIds are still set by string instead of by TypeId.  Should we update all such setters to use TypeId, or revert the above change?

Also, a minor point, the Doxygen on SetPathlossModelType() should be aligned with the API change.