Bug 2878 – code review: 802.11 PCF

Bug 2878 - code review: 802.11 PCF


Summary:	code review: 802.11 PCF

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	wifi
Version:	unspecified
Hardware:	All All

Importance:	P3 enhancement
Assigned To:	sebastien.deronne

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2018-02-18 14:27 EST by sebastien.deronne
Modified:	2018-05-21 09:09 EDT (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description sebastien.deronne 2018-02-18 14:27:29 EST

I had started 802.11 PCF implementation few years ago, but then I had to pauze for priority reasons. I saw again some interests for having 802.11 PCF in ns-3 so I reworked my initial development. This has already been quite intensively tested by some people and myself.

Rietveld issue:
https://codereview.appspot.com/333660043/

Note that it does not introduce any regression, none of the PCF code is run if it is not enabled (disabled by default). As a result, I stay confident to have it merged in ns-3-dev quite soon, so that we can avoid continuous merge issues and start a new repository for HCCA.

Any comments are welcome. I do not pretend this is the best approach, so feel free to propose a different one, but I tried to minimize impacts in the current code.

N.B.: I still need to update the current patch set to include an example.

Comment 1 sebastien.deronne 2018-02-20 16:09:05 EST

Patch set updated with an example

Comment 2 sebastien.deronne 2018-03-28 05:50:25 EDT

Now that the released is passed, I will merge with the latest ns-3-dev stream and I intend to push this early next week. This should not break anything since everything is protected by PcfSupported capability flags.

Comment 3 sebastien.deronne 2018-05-21 09:09:16 EDT

Code pushed in changeset 13557:1d9389d67836.
I still need to do some minor updates in the documentation.