Bug 2912 – code review: add ENU coordinates handling to geographic positions

Bug 2912 - code review: add ENU coordinates handling to geographic positions


Summary:	code review: add ENU coordinates handling to geographic positions

Status:	PATCH PENDING

Product:	ns-3
Classification:	Unclassified
Component:	mobility models
Version:	unspecified
Hardware:	All All

Importance:	P3 normal
Assigned To:	ns-bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2018-04-23 17:35 EDT by Tom Henderson
Modified:	2018-04-26 10:39 EDT (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tom Henderson 2018-04-23 17:35:56 EDT

Please comment on the code found at:  https://github.com/mirad/ns-3-dev-git/commit/48384437c1face4fb1ab4a258c3d2ff96d69c7c2

Comment 1 Michael Rademacher 2018-04-26 10:39:51 EDT

I have updated the repo to account for the following comment:

I had a quick look and it seems fine,
except for the Copyright notice (it is for an old year and for Univ. of
Washington, so it seems a copy/paste) and for the unconsistent style of
doxygen tags (e.g., \param vs @param).

from Natale Patriciello on the ns-dev mailing-list. 

A comparison between my branch and ns-3 master can be found under this link.

https://github.com/nsnam/ns-3-dev-git/compare/master...mirad:enu-coordinates