Bug 414 - No ReceiveErrorModel in SimpleNetDevice
No ReceiveErrorModel in SimpleNetDevice
Status: RESOLVED FIXED
Product: ns-3
Classification: Unclassified
Component: network
ns-3-dev
All All
: P3 normal
Assigned To: Tom Henderson
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-11-17 22:48 EST by Craig Dowell
Modified: 2010-03-05 23:52 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Dowell 2008-11-17 22:48:53 EST
There presently is no ReceiveErrorModel attribute in Bridge, SimpleNetDevice, or Wifi.  I (tomh) would also propose to add this attribute to SimpleNetDevice, at the very least.  Is there a reason why not to include in all current NetDevices?
Comment 1 Craig Dowell 2008-12-03 17:19:52 EST
It has been decided to reduce priority and ask for comments on the list.
Comment 2 Mathieu Lacage 2008-12-10 05:40:28 EST
(In reply to comment #0)
> There presently is no ReceiveErrorModel attribute in Bridge, SimpleNetDevice,
> or Wifi.  I (tomh) would also propose to add this attribute to SimpleNetDevice,
> at the very least.  Is there a reason why not to include in all current
> NetDevices?

yes, such a feature is part of the "PHY" layer modeling. In wifi, this modeling is performed by the WifiPhy subclasses. The only such subclass (for now) is YansWifiPhy and this PHY model has nothing to do with a ReceiveErrorModel class. 

I would be fine with another WifiPhy subclass which performs packet error modeling based on a ReceiveErrorModel class.

Another way to integrate this in the current YansWifiPhy model would be to implement a subclass of the ErrorRateModel which uses a ReceiveErrorModel to return either 0 or 1.



Comment 3 Mathieu Lacage 2009-11-23 09:14:35 EST
Shall we not just close this bug as INVALID since I doubt anyone will ever do any work to make _every_ NetDevice subclass use an ErrorModel subclass.
Comment 4 Tom Henderson 2009-11-24 00:09:44 EST
(In reply to comment #3)
> Shall we not just close this bug as INVALID since I doubt anyone will ever do
> any work to make _every_ NetDevice subclass use an ErrorModel subclass.


I will take it.  I want to add this to SimpleNetDevice.  Changed title to reflect.
Comment 5 Tom Henderson 2010-03-05 23:52:52 EST
changeset: c204cb0f18d8