Bug 683 - Helper methods for pcap tracing with explicit filenames
Helper methods for pcap tracing with explicit filenames
Status: RESOLVED FIXED
Product: ns-3
Classification: Unclassified
Component: helpers
ns-3-dev
All All
: P5 enhancement
Assigned To: Craig Dowell
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-20 21:57 EDT by Martín Ferrari
Modified: 2010-02-26 13:32 EST (History)
2 users (show)

See Also:


Attachments
New pcap helpers (11.80 KB, patch)
2009-09-20 21:57 EDT, Martín Ferrari
Details | Diff
Python bindings for the new helpers (4.57 KB, patch)
2009-09-20 21:57 EDT, Martín Ferrari
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martín Ferrari 2009-09-20 21:57:16 EDT
Created attachment 595 [details]
New pcap helpers

This was sent to the ML on 31/8, but went unnoticed, so I post it as a wishlist bug. I've also just read that ns-3 is on maintenance phase, but I'd like to ask its inclusion to be considered.

-------------

For a project I'm working on, I need to set up pcap tracing while
being able to define exactly which filename the traces will have. Now,
the helper methods unconditionally append the node and device ids and
the ".pcap" suffix. I've created a patch that defines a new method
EnablePcapExplicit with exactly the same arguments as EnablePcap, but
doesn't append anything to the filename argument. ATM, I'd just
implemented overloaded methods for the nodeid+deviceid and device ptr
versions, but if you think it's worthwhile, I can add equivalent
methods for the other signatures of EnablePcap.

I've also included the updated bindings for this.

I'd like to ask you to consider merging this functionality. Maybe
you'd prefer a different method name, or some different organisation.
What I'd like to avoid is any diversion from the ns-3-dev main tree.

Thanks, Martín.

PS: please note that the current revision of ns-3-dev has some of the
bindings out of sync. When I run --python-scan, these files are
modified:
M bindings/python/ns3_module_core.py
M bindings/python/ns3_module_internet_stack.py
M bindings/python/ns3_module_wifi.py
Comment 1 Martín Ferrari 2009-09-20 21:57:55 EDT
Created attachment 596 [details]
Python bindings for the new helpers
Comment 2 Craig Dowell 2009-12-03 15:54:26 EST
I am addressing this along with 682.  I have a patch that I am not entirely satisfied with.  I will address this after I complete some other work -- before code complete ns-3.7
Comment 3 Craig Dowell 2010-01-11 13:08:53 EST
Will push after 3.7
Comment 4 Craig Dowell 2010-02-26 13:32:16 EST
changeset 94b282f335d2