Bug 900 – RawTestConfigLoad::Default does not load configurations

Bug 900 - RawTestConfigLoad::Default does not load configurations


Summary:	RawTestConfigLoad::Default does not load configurations

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	general
Version:	ns-3.7
Hardware:	All All

Importance:	P3 normal
Assigned To:	ns-bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-04-29 02:45 EDT by Quincy Tse
Modified:	2010-05-30 23:45 EDT (History)
CC List:	1 user (show)

See Also:

Attachments
Proposed patch. (447 bytes, patch) 2010-05-30 22:07 EDT, Quincy Tse	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Quincy Tse 2010-04-29 02:45:17 EDT

RawTestConfigLoad::Default() checks for type == "global" instead of "default" on line 123, hence defaults values are not loaded.

Comment 1 Quincy Tse 2010-05-30 22:07:20 EDT

Created attachment 899 [details]
Proposed patch.

Proposed patch fixing the bug. I haven't changed the layout of the code though (it doesn't conform to the coding style). I can change the layout as well though.

Comment 2 Tom Henderson 2010-05-30 23:44:28 EDT

changeset:  06d80fe1d3b0

Comment 3 Tom Henderson 2010-05-30 23:45:02 EDT

(In reply to comment #1)
> Created an attachment (id=899) [details]
> Proposed patch.
> 
> Proposed patch fixing the bug. I haven't changed the layout of the code though
> (it doesn't conform to the coding style). I can change the layout as well
> though.

I think we can handle the layout issue once we move it out of src/contrib in a future release cycle.