Bug 908 – test.py should exit if waf dies

Bug 908 - test.py should exit if waf dies


Summary:	test.py should exit if waf dies

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	test framework
Version:	ns-3-dev
Hardware:	All All

Importance:	P5 minor
Assigned To:	ns-bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-05-08 07:00 EDT by Andrey Mazo
Modified:	2010-05-22 12:43 EDT (History)
CC List:	2 users (show)

See Also:

Attachments
proposed fix (442 bytes, patch) 2010-05-08 07:00 EDT, Andrey Mazo	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andrey Mazo 2010-05-08 07:00:15 EDT

Created attachment 866 [details]
proposed fix

Currently test.py runs waf by default before executing tests, but doesn't check its return code.
So it's possible for waf to die with compilation error and test.py to run tests against mixture of old and new libraries/executables.
It may introduce some problems to an inattentive user.

Comment 1 Gustavo J. A. M. Carneiro 2010-05-17 06:43:26 EDT

(In reply to comment #0)
> Created an attachment (id=866) [details]
> proposed fix

Looks good.  Craig, you still around? :-)

Comment 2 Craig Dowell 2010-05-22 12:43:01 EDT

Fixed changeset 1f53e122254b

> Craig, you still around? :-)

No.  I find myself in an alternate universe where everything starts with "Q" and there are strange rituals called "meetings".