Bug 924 – Inconsistent declaration of class/struct in <xxx>-wifi-managers

Bug 924 - Inconsistent declaration of class/struct in <xxx>-wifi-managers


Summary:	Inconsistent declaration of class/struct in <xxx>-wifi-managers

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	wifi
Version:	ns-3-dev
Hardware:	All All

Importance:	P5 normal
Assigned To:	Nicola Baldo

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-05-27 22:12 EDT by Quincy Tse
Modified:	2010-06-07 10:35 EDT (History)
CC List:	1 user (show)

See Also:

Attachments
Proposed patch. (1.81 KB, patch) 2010-05-27 22:12 EDT, Quincy Tse	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Quincy Tse 2010-05-27 22:12:07 EDT

Inconsistent declaration of the following as class/struct triggering static
analysis warnings. No actual functional deficiencies.

* amrr-wifi-manager
* onoe-wifi-manager
* rraa-wifi-manager
* aarfcd-wifi-manager
* minstrel-wifi-manager

../src/devices/wifi/amrr-wifi-manager.cc:31:1: error: struct
      'AmrrWifiRemoteStation' was previously declared as a class
      [-Wmismatched-tags]
struct AmrrWifiRemoteStation : public WifiRemoteStation
^~~~~~
class
In file included from ../src/devices/wifi/amrr-wifi-manager.cc:21:
../src/devices/wifi/amrr-wifi-manager.h:28:7: note: previous use is here
class AmrrWifiRemoteStation;
      ^
1 error generated.

../src/devices/wifi/onoe-wifi-manager.cc:30:1: error: struct
      'OnoeWifiRemoteStation' was previously declared as a class
      [-Wmismatched-tags]
struct OnoeWifiRemoteStation : public WifiRemoteStation
^~~~~~
class
In file included from ../src/devices/wifi/onoe-wifi-manager.cc:21:
../src/devices/wifi/onoe-wifi-manager.h:28:7: note: previous use is here
class OnoeWifiRemoteStation;
      ^
1 error generated.

etc.

Comment 1 Quincy Tse 2010-05-27 22:12:32 EDT

Created attachment 892 [details]
Proposed patch.

Comment 2 Nicola Baldo 2010-06-03 05:03:44 EDT

Hi Quincy,

(In reply to comment #0)
> Inconsistent declaration of the following as class/struct triggering static
> analysis warnings. No actual functional deficiencies.

Thank you for this patch. I agree that there is an inconsistency and I am ok in principle with the proposed change. 
The only thing is that, it seems that this bug addresses the same issue as bug 922 which was recently posted by you, though the prosed patches differ. Can you please point us which is the patch that you finally propose to apply?

Comment 3 Nicola Baldo 2010-06-07 10:35:09 EDT

changeset:   6340:fe24c9edacb6