Bug 987 – DcaTxop and EdcaTxop have a lot of common code

Bug 987 - DcaTxop and EdcaTxop have a lot of common code


Summary:	DcaTxop and EdcaTxop have a lot of common code

Status:	RESOLVED INVALID

Product:	ns-3
Classification:	Unclassified
Component:	wifi
Version:	ns-3-dev
Hardware:	All All

Importance:	P5 enhancement
Assigned To:	sebastien.deronne

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-08-27 09:42 EDT by Nicola Baldo
Modified:	2015-09-28 07:58 EDT (History)
CC List:	2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Nicola Baldo 2010-08-27 09:42:17 EDT

From a discussion within bug 978:

Kirill wrote:
> First is, that DcaTxop and EdcaTxop have a lot of common code (an aggregation
> is an only difference, as it seems to me), and if this two classes can be
> merged in a single class with "Enable-N-Aggregation" option.

Comment 1 sebastien.deronne 2015-09-11 15:45:46 EDT

I do not agree to merge those classes.
I guess a lot more of code has been added in EdcaTxopN in the meanwhile.

Comment 2 Tom Henderson 2015-09-17 23:51:45 EDT

(In reply to sebastien.deronne from comment #1)
> I do not agree to merge those classes.
> I guess a lot more of code has been added in EdcaTxopN in the meanwhile.

+1

Comment 3 sebastien.deronne 2015-09-28 07:58:57 EDT

This is not ok to merge edcatxop with dcatxop.