HOWTO control Rietveld patch generation - Revision history

Tomh at 16:44, 4 July 2016

2016-07-04T16:44:30Z

← Older revision		Revision as of 16:44, 4 July 2016
Line 1:		Line 1:
	{{TOC}}		{{TOC}}

			== Authentication flow ==

			As of mid-2015, Google changed authentication, and users need to pass either '--oauth2' or '--no_oauth2_webbrowser' options for upload.py., e.g.

			python ../upload.py --oauth2 --issue=293380043 --rev=12096

			If you use the '--oauth2' option for browser-based authentication, you may see this kind of response, in which case you must visit the page requested and sign in to complete the upload:

			Your browser has been opened to visit:
			https://codereview.appspot.com/get-access-token?port=8001
			If your browser is on a different machine then exit and re-run
			upload.py with the command-line parameter
			--no_oauth2_webbrowser

	== Password authentication errors ==		== Password authentication errors ==

Tomh: fix typo

2016-07-04T15:06:01Z

fix typo

← Older revision		Revision as of 15:06, 4 July 2016
Line 120:		Line 120:


	=== Git example =====		=== Git example ===
	you can do		you can do
	./upload.py [options] -- [diff options]		./upload.py [options] -- [diff options]
	the [diff options] part will be forwarded to git diff; hence you can launch for instance:		the [diff options] part will be forwarded to git diff; hence you can launch for instance:
	./upload.py --oauth2 -- master..HEAD		./upload.py --oauth2 -- master..HEAD

Teto at 18:19, 5 December 2015

2015-12-05T18:19:31Z

@@ Line 22: / Line 22: @@
    __main__.ClientLoginError: HTTP Error 403: Forbidden
-You may need to pass the '--oauth2' flag to upload.py and use browser-based authentication (due to Google authentication changes around mid-2015).
+or this
 == Updating an existing code issue with an additional patch ==
@@ Line 90: / Line 118: @@
 Note that this is unlike the previous example in this HOWTO where we wanted 8954:8956 to be included.

Tomh: /* Password authentication errors */

2015-06-12T01:30:45Z

Password authentication errors

← Older revision		Revision as of 01:30, 12 June 2015
Line 22:		Line 22:
	__main__.ClientLoginError: HTTP Error 403: Forbidden		__main__.ClientLoginError: HTTP Error 403: Forbidden

	You may need to pass the '--oauth2'' flag to upload.py and use browser-based authentication (due to Google authentication changes around mid-2015).		You may need to pass the '--oauth2' flag to upload.py and use browser-based authentication (due to Google authentication changes around mid-2015).

	== Updating an existing code issue with an additional patch ==		== Updating an existing code issue with an additional patch ==

Tomh: oath2 hint

2015-06-12T01:30:01Z

oath2 hint

← Older revision		Revision as of 01:30, 12 June 2015
Line 1:		Line 1:
	{{TOC}}		{{TOC}}

			== Password authentication errors ==

			If you get this kind of error message when using upload.py:

			Traceback (most recent call last):
			File "upload.py", line 2719, in <module>
			main()
			File "upload.py", line 2711, in main
			RealMain(sys.argv)
			File "upload.py", line 2667, in RealMain
			response_body = rpc_server.Send("/upload", body, content_type=ctype)
			File "upload.py", line 474, in Send
			self._Authenticate()
			File "upload.py", line 501, in _Authenticate
			super(HttpRpcServer, self)._Authenticate()
			File "upload.py", line 381, in _Authenticate
			auth_token = self._GetAuthToken(credentials[0], credentials[1])
			File "upload.py", line 335, in _GetAuthToken
			e.headers, response_dict)
			__main__.ClientLoginError: HTTP Error 403: Forbidden

			You may need to pass the '--oauth2'' flag to upload.py and use browser-based authentication (due to Google authentication changes around mid-2015).

	== Updating an existing code issue with an additional patch ==		== Updating an existing code issue with an additional patch ==

Tomh: more hints for Rietveld

2013-03-22T19:11:45Z

more hints for Rietveld

@@ Line 1: / Line 1: @@
 {{TOC}}
-== Applying different changsets to different patchsets==
+== Updating an existing code issue with an additional patch ==
 Assume that you have a repository with two changesets that you want reviewed as separate patchsets (i.e. you want Rietveld to preserve the changesets and not merge them into a single patch).  See this code issue as an example:  http://codereview.appspot.com/6443113
@@ Line 46: / Line 65: @@
    Uploading base file for src/buildings/helper/building-position-allocator.h
    ...

Tomh: Rietveld HOWTO

2012-08-10T21:57:20Z

Rietveld HOWTO

New page

{{TOC}}

== Applying different changsets to different patchsets==

Assume that you have a repository with two changesets that you want reviewed as separate patchsets (i.e. you want Rietveld to preserve the changesets and not merge them into a single patch). See this code issue as an example: http://codereview.appspot.com/6443113

Assume that 8954 is the base, 8954:8955 is the first changeset, and 8955:8956 is the second changeset.

changeset: 8956:208d6b79fa5d
tag: tip
user: Tom Henderson <tomh@tomh.org>
date: Fri Aug 10 14:37:46 2012 -0700
summary: Add AssignStreams support to mobility code

changeset: 8955:38db106173a9
user: Tom Henderson <tomh@tomh.org>
date: Thu Aug 09 10:53:04 2012 -0700
summary: port mobility-related code to RandomVariableStream

changeset: 8954:505e3a5b7c80
user: Tom Henderson <tomh@tomh.org>
date: Wed Aug 01 13:19:33 2012 -0700
summary: bug 1386: assert if PositionAllocator not provided to RandomWaypointMobilityModel

The first one is uploaded by specifying the revisions explicitly:

$ python upload.py --rev=8954:8955
Upload server: codereview.appspot.com (change with -s/--server)
Loaded authentication cookies from /home/tomh/.codereview_upload_cookies
New issue subject: replace src/mobility usage of RandomVariable with RandomVariableStream"
Issue created. URL: http://codereview.appspot.com/6443113
Uploading base file for src/mobility/model/gauss-markov-mobility-model.h
Uploading base file for src/mobility/model/random-direction-2d-mobility-model.h
Uploading base file for src/wimax/examples/wimax-multicast.cc
...

For your second upload, specify the second revision, and identify the previous issue:

$ python upload.py --rev=8955:8956 --issue=6443113
Upload server: codereview.appspot.com (change with -s/--server)
Loaded authentication cookies from /home/tomh/.codereview_upload_cookies
Title describing this patch set: add AssignStreams
Issue updated. URL: http://codereview.appspot.com/6443113
Uploading base file for examples/routing/manet-routing-compare.cc
Uploading base file for src/buildings/helper/building-position-allocator.cc
Uploading base file for src/buildings/helper/building-position-allocator.h
...