Bugzilla – Bug 1106
Remove "CanvasLocation" dependencies in p2p helpers
Last modified: 2011-04-22 15:45:01 EDT
The current p2p helpers depend on "CanvasLocation". However, as other modules such as wireless and pyviz use "MobilityModels" for node-placement, the "CanvasLocation" dependencies can be changed to a dependency on "MobilityModels".
Created attachment 1085 [details] Removing CanvasLocation dependencies in NetAnim and examples/matrix-topology
Created attachment 1086 [details] Py bindings to be scanned later. Diff of changes in NetAnim and examples/matrix-topology
This patch looks right to me. Did you test this out with net-anim to make sure the topologies still looked right? Also, you can try it in pyviz now too, and it should pick up on the mobility model and look the same as netanim now! Finally, is there any reason to keep CanvasLocation around any more?
Created attachment 1088 [details] New patch removing canvas-location.cc and .h
Created attachment 1089 [details] dumbbell using pyViz after changes dumbbell using pyViz after changes
Created attachment 1090 [details] dumbbell before changes, using pyviz