Bug 404 - ErrorModel attribute name is not consistent across devices
: ErrorModel attribute name is not consistent across devices
Status: RESOLVED FIXED
: ns-3
devices
: ns-3-dev
: All All
: P2 normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2008-11-07 10:39 EDT by
Modified: 2008-11-17 22:45 EDT (History)


Attachments


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2008-11-07 10:39:22 EDT
IMO, the name of this attribute should be aligned across devices, even though
it is an API change.

In PointToPoint:
                   .AddAttribute ("ReceiveErrorModel",
                   "The receiver error model used to simulate packet loss",
                   PointerValue (),
                   MakePointerAccessor
(&PointToPointNetDevice::m_receiveErrorModel),
                   MakePointerChecker<ErrorModel> ())

In CSMA:
                   .AddAttribute ("RxErrorModel",
                   "The receiver error model used to simulate packet loss",
                   PointerValue (),
                   MakePointerAccessor (&CsmaNetDevice::m_receiveErrorModel),
                   MakePointerChecker<ErrorModel> ())

(Note:  there presently is no ReceiveErrorModel in Bridge, SimpleNetDevice, or
Wifi.  I would also propose to add this attribute to SimpleNetDevice, at the
very least, once the naming alignment is settled.  Is there a reason why not to
include in all current NetDevices?)